Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass COM caller name to rest source in request header #3112

Merged
merged 3 commits into from Mar 29, 2023

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Mar 28, 2023

Added unit tests and tested manually.

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@yao-msft yao-msft requested a review from a team as a code owner March 28, 2023 21:34
virtual bool SetCustomHeader(std::optional<std::string> header) { UNREFERENCED_PARAMETER(header); return false; }
virtual bool SetCustomHeader(std::optional<std::string>) { return false; }

// Set custom header. Returns false if custom header is not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns false if custom header is not supported.

Update comment: Doesn't return a bool

@yao-msft yao-msft merged commit dddc094 into microsoft:master Mar 29, 2023
8 checks passed
@yao-msft yao-msft deleted the useragentcaller branch March 29, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants