Update README.md #3148
Merged
Update README.md #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
force-pushed
the
update-readme
branch
from
5882502
to
786c15a
Compare
|
@Trenly, you went through some of this as well. Do you have anything to add here? |
Trenly
reviewed
Apr 13, 2023
Nothing to add; I might suggest specific documentation on how to run the Unit Tests, but thats a separate PR. |
|
The project also depends on
I decided not to include it in the README in case the project gets updated to target a new version (3.1 is EOL anyways). Let me know though, if this is something that still should be documented and I'll update it in the PR. |
denelon
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The commit messages describe each change but I'll provide further description for few of the changes:
Build Instructions:
Windows 10 SDK, version 2004 is required to build AppInstallerCLIPackage which is not installed via the workloads mentioned in the instructions. For me, on Visual Studio 2022 17.4.4, the workloads install Windows SDK for Windows 11 and I had to manually install the older version.
P.S.: I could not figure out how to debug the winget-cli codebase (yes i'm a newbie with Visual Studio). I did get it to build and deploy, and successfully run
wingetdev, but I'm not sure how to debug the code. If the reviewers can suggest changes for the debug instructions / update the guide themselves, it would be much appreciated!Microsoft Reviewers: Open in CodeFlow