Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prerelease modules for configuration #3217

Merged
merged 4 commits into from May 8, 2023

Conversation

msftrubengu
Copy link
Contributor

@msftrubengu msftrubengu commented May 4, 2023

This PR allows a configuration file to have a boolean allowPrerelease directive to use prerelease DSC resources.

properties:
  configurationVersion: 0.2
  resources:
    - resource: FakeModule/FakeResource
      directives:
        version: '1.0.0-preview'
        allowPrerelease: true
      settings:
        Args: 'args'

Internally, allow prerelease is used only for a module that it needs to get install. When is enabled, the processor will use -AllowPrerelease to the Find-DscResource command.

It also fixes and infinite loop in SplitIntoLines. If the found offset is the one of "\r\n", it uses the same offset for pos in find_first_of, so it keeps returning the offset making nextOffset - currentOffset = 0

I don't know why VisualStudio decided to change a character...

Microsoft Reviewers: Open in CodeFlow

@msftrubengu msftrubengu requested a review from a team as a code owner May 4, 2023 06:10
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@denelon
Copy link
Contributor

denelon commented May 8, 2023

Do we need to modify the JSON schema for this?
Or create a 0.2 JSON schema?

@msftrubengu
Copy link
Contributor Author

I can create the schema in another PR.

@msftrubengu msftrubengu merged commit 7eca519 into microsoft:master May 8, 2023
8 checks passed
@msftrubengu msftrubengu deleted the allowprerelease branch August 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants