Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ${WinGetConfigRoot} variable expansion #3237

Merged
merged 3 commits into from May 10, 2023

Conversation

msftrubengu
Copy link
Contributor

@msftrubengu msftrubengu commented May 10, 2023

Allow settings to use the $WinGetConfigRoot variable.

This variable means the directory containing the configuration file and is helpful for units that want reference paths that are relative to the location of the configuration file.

For example, our test resource can use it like this:

properties:
  configurationVersion: 0.2
  resources:
    - resource: xSimpleTestResource/SimpleFileResource
      settings:
        path: '${WinGetConfigRoot}\..\test.txt'
        content: 'Ella baila sola'

To make it PowerShelly, the variable expansion is done ignoring case.

Since this is still in preview, the name of the variable can change when winget configure release.

Microsoft Reviewers: Open in CodeFlow

@msftrubengu msftrubengu requested a review from a team as a code owner May 10, 2023 00:48
@github-actions

This comment has been minimized.

@JohnMcPMS
Copy link
Member

This variable means the current location of the configuration file and is helpful for units that want reference paths that are relative to the location of the configuration file.

I assume you mean "the directory containing the configuration file".

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback Issue needs attention from issue or PR author and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels May 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label May 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback Issue needs attention from issue or PR author label May 10, 2023
@msftrubengu msftrubengu changed the title Allow $WinGetConfigRoot variable expansion Allow ${WinGetConfigRoot} variable expansion May 10, 2023
@msftrubengu msftrubengu merged commit 40d9cd3 into microsoft:master May 10, 2023
8 checks passed
@msftrubengu msftrubengu deleted the configroot branch August 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants