Add try/catch when reading upgrade codes #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrubengu
approved these changes
Sep 18, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
added
the
Issue-Bug
JohnMcPMS
added a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Despite the look of the diff on github, this change only adds two try/catch blocks to the upgrade code parsing code to prevent failures from propagating out. The upgrade codes are just additional data to help with correlations and should not cause additional user impact beyond not being present.
The outer block protects against the primary key throwing, as well as the subkey enumeration.
The inner block protects against a single upgrade code key throwing, while allowing the loop to potentially continue.
Validation
Code inspection only.
Microsoft Reviewers: Open in CodeFlow