Allow higher versions to satisfy the VCLibs dependency in Repair #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Oct 12, 2023
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Nov 8, 2023
Rather than looking for the explicit version of the VCLibs dependency, this change allows any version greater than or equal to satisfy the installed check. This does not resolve the fact that we are using a hardcoded version, nor that we are not checking for the same set of architectures that we would install. Also fixes the helper script to import the dev modules directly so that it can be used even when the release modules are present in the module path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Rather than looking for the explicit version of the VCLibs dependency, this change allows any version greater than or equal to satisfy the installed check.
This does not resolve the fact that we are using a hardcoded version, nor that we are not checking for the same set of architectures that we would install.
Also fixes the helper script to import the dev modules directly so that it can be used even when the release modules are present in the module path.
Validation
Stepped through to confirm, added debug output as well.
Microsoft Reviewers: Open in CodeFlow