Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip dependency evaluation with --skip-dependencies #3784

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Skip dependency evaluation with --skip-dependencies #3784

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c33686e
Skip dependency evaluation with --skip-dependencies
mdanish-kh Oct 18, 2023
f464f31
move check to the top
mdanish-kh Oct 18, 2023
2aae4da
fix alignment
mdanish-kh Oct 18, 2023
374bea6
tabs vs spaces
mdanish-kh Oct 18, 2023
4c90716
try removing OverrideOpenDependencySource
mdanish-kh Oct 19, 2023
016da35
fix another test case
mdanish-kh Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AppInstallerCLICore/Workflows/DependenciesFlow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,9 @@ namespace AppInstaller::CLI::Workflow
const auto& rootInstaller = context.Get<Execution::Data::Installer>();
const auto& rootDependencies = rootInstaller->Dependencies;

if (rootDependencies.Empty())
if (rootDependencies.Empty() || context.Args.Contains(Execution::Args::Type::SkipDependencies))
mdanish-kh marked this conversation as resolved.
Show resolved Hide resolved
{
// If there's no dependencies there's nothing to do aside of logging the outcome
// If there's no dependencies or user skips them, there's nothing to do aside of logging the outcome
return;
}

Expand Down