Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-test hook code for Windows Feature #3789

Merged
merged 1 commit into from Oct 19, 2023

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Oct 19, 2023

Change

Move the Windows Feature dism.exe calling code around and make the test hook return from the primary function. This ensures that all code is being compiled when test hooks are enabled, and the test hooks are simple, early returns.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner October 19, 2023 01:28
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit b96dbdb into microsoft:master Oct 19, 2023
8 checks passed
@JohnMcPMS JohnMcPMS deleted the fix-win-feat branch October 19, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants