Allow Microsoft.WinGet.Client to run in any PowerShell session running as system #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrubengu
changed the title
Clemens-git76
approved these changes
Nov 2, 2023
Clemens-git76
approved these changes
Nov 2, 2023
Clemens-git76
approved these changes
Nov 2, 2023
Clemens-git76
approved these changes
Nov 2, 2023
JohnMcPMS
previously approved these changes
Nov 10, 2023
|
|
||
| /// <summary> | ||
| /// Gets or sets how to match against package fields. | ||
| /// </summary> | ||
| protected string[] Query { get; set; } | ||
| #pragma warning disable SA1011 // Closing square brackets should be spaced correctly | ||
| protected string[]? Query { get; set; } |
There was a problem hiding this comment.
Academic question: Does string?[] mean a non-null array of nullable strings, while string[]? means a nullable array of non-null strings? If so, then string?[]? is a lovingly confusing type name 😄
There was a problem hiding this comment.
Yup. There's another place where I needed a non-nullable array with nullable objects, so it was object?[]
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/PackageManagerWrapper.cs
Outdated
Show resolved
Hide resolved
JohnMcPMS
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running the Microsoft.WinGet.Client module in system context without the need to start pwsh.exe -MTA. Running as MTA is required using inproc Microsoft.Management.Deployment.
If the module is running inproc and the current thread is not an MTA, it will create a new MTA thread and execute there. Otherwise, non inproc or already an MTA will use the current thread.
This was done by sharing AsyncCommand (renamed to PowerShellCmdlet) from Microsoft.WinGet.Configuration. Originally, I wanted to create a new shared lib, but decided to just share the files between the projects.
All cmdlets must inherit from PowerShellCmdlet. All cmdlets that use Microsoft.Management.Deployment must inherit ManagementDeploymentCommand and use Execute at the command engine entry point. As a safe mechanism, if any call to PackageManagerWrapper will verify the thread is not an STA if running inproc and fail.
I verified the cmdlets work in system context locally. A future PR will add running our pester tests using psexe.exe
Microsoft Reviewers: Open in CodeFlow