Revert manifest schemas to json draft-07 #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Nov 10, 2023
Madhusudhan-MSFT
added a commit
to Madhusudhan-MSFT/winget-cli
that referenced
this pull request
Nov 10, 2023
yao-msft
pushed a commit
to yao-msft/winget-cli
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3478
The library that winget-create depends on to convert the json schema to C# model classes does not support json schema 2020-12, specifically the new
$defskeyword.Although we should be updating to the latest schema, we need to unblock winget-create in order to support updating 1.6 manifests. In the meantime, we will need to find an alternative library/solution that can be utilized by winget-create
Microsoft Reviewers: Open in CodeFlow