Fix pipeline build error #3937
Merged
Fix pipeline build error #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Nov 29, 2023
yao-msft
pushed a commit
to yao-msft/winget-cli
that referenced
this pull request
Dec 20, 2023
This fixes the recent build errors in the pipelines. The compiler was complaining about re-throwing an exception with `throw e;` instead of `throw;`, which messes with the stack trace. Presumably it started because of a tool update in the agents. This also fixes a compilation error I'm seeing locally from a member not being initialized.
yao-msft
added a commit
that referenced
this pull request
Dec 20, 2023
Fix pipeline build error (#3937)
florelis
added a commit
to florelis/winget-cli
that referenced
this pull request
Jan 11, 2024
This fixes the recent build errors in the pipelines. The compiler was complaining about re-throwing an exception with `throw e;` instead of `throw;`, which messes with the stack trace. Presumably it started because of a tool update in the agents. This also fixes a compilation error I'm seeing locally from a member not being initialized.
florelis
added a commit
that referenced
this pull request
Jan 11, 2024
This fixes the recent build errors in the pipelines. The compiler was complaining about re-throwing an exception with `throw e;` instead of `throw;`, which messes with the stack trace. Presumably it started because of a tool update in the agents. This also fixes a compilation error I'm seeing locally from a member not being initialized. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4063)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the recent build errors in the pipelines. The compiler was complaining about re-throwing an exception with
throw e;instead ofthrow;, which messes with the stack trace. Presumably it started because of a tool update in the agents.This also fixes a compilation error I'm seeing locally from a member not being initialized.
Microsoft Reviewers: Open in CodeFlow