Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment around MotW application #3979

Merged
merged 1 commit into from Dec 15, 2023
Merged

Update comment around MotW application #3979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/AppInstallerCLICore/Workflows/DownloadFlow.cpp
View file
Open in desktop
Expand Up @@ -456,14 +456,20 @@ namespace AppInstaller::CLI::Workflow

void UpdateInstallerFileMotwIfApplicable(Execution::Context& context)
{
// An initial MotW is always set to URLZONE_INTERNET at the time the file is downloaded.
// This function may change that to URLZONE_TRUSTED if appropriate
if (context.Contains(Execution::Data::InstallerPath))
{
if (WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::InstallerTrusted))
{
// We know the installer already went through multiple scans and we can trust it.
Utility::ApplyMotwIfApplicable(context.Get<Execution::Data::InstallerPath>(), URLZONE_TRUSTED);
}
else if (WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::InstallerHashMatched))
{
// IAttachmentExecute performs some additional scans before setting MotW, for example invoking anti-virus.
// A policy can be set to always mark files from a given domain as trusted, so only do this
// on installers with the right hash to prevent trusting unknown installers.
const auto& installer = context.Get<Execution::Data::Installer>();
HRESULT hr = Utility::ApplyMotwUsingIAttachmentExecuteIfApplicable(context.Get<Execution::Data::InstallerPath>(), installer.value().Url, URLZONE_INTERNET);

Expand Down