New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show only agreement related info during install #3999
Conversation
cc @yao-msft and @ryfu-msft in case this could also make it into the servicing release |
If we want to emphasize agreements in the prompts, I think we should modify the ShowPackageAgreements method to show agreements + basic necessary info only, and not reusing the ShowPackageInfo directly. We may add more things to "winget show" for package info in the future, and if we don't remember to treat them separately for ShowAgreementsOnly, it will be shown in ShowPackageAgreements. |
We just did a servicing release yesterday, so it will be in next servicing release if we decide to do one. Sorry.. |
I don't have any concerns with the different output formatting for the Agreements flow. |
Great point; Thanks for the feedback - will update |
78ed0ce
to
8fd9b36
Compare
Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR cleans up the install flow to make it easier for a user to see the agreements of the package. It does this by changing the install flow to not show fields that are unrelated to package agreements such as
Screenshots included below to show difference between old and new
Old MSStore Agreements Shown
New MSStore Agreements Shown
Old Local Manifest Agreements Shown
New Local Manifest Agreements Shown
Microsoft Reviewers: Open in CodeFlow