Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only agreement related info during install #3999

Merged
merged 4 commits into from Jan 25, 2024

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Dec 19, 2023

This PR cleans up the install flow to make it easier for a user to see the agreements of the package. It does this by changing the install flow to not show fields that are unrelated to package agreements such as

  • Moniker
  • Description
  • PackageUrl
  • ReleaseNotes
  • ReleaseNotesUrl
  • InstallationNotes
  • Documentations
  • Tags

Screenshots included below to show difference between old and new

Old MSStore Agreements Shown

image

New MSStore Agreements Shown

image

Old Local Manifest Agreements Shown

image

New Local Manifest Agreements Shown

image


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner December 19, 2023 23:46
@Trenly
Copy link
Contributor Author

Trenly commented Dec 19, 2023

cc @yao-msft and @ryfu-msft in case this could also make it into the servicing release
cc @denelon for legal

@yao-msft
Copy link
Contributor

If we want to emphasize agreements in the prompts, I think we should modify the ShowPackageAgreements method to show agreements + basic necessary info only, and not reusing the ShowPackageInfo directly. We may add more things to "winget show" for package info in the future, and if we don't remember to treat them separately for ShowAgreementsOnly, it will be shown in ShowPackageAgreements.

@yao-msft
Copy link
Contributor

cc @yao-msft and @ryfu-msft in case this could also make it into the servicing release cc @denelon for legal

We just did a servicing release yesterday, so it will be in next servicing release if we decide to do one. Sorry..

@denelon
Copy link
Contributor

denelon commented Dec 20, 2023

I don't have any concerns with the different output formatting for the Agreements flow.
No fields were removed from the "msstore" source, and the ones pruned from the community repository are fine as they are still visible via winget show and from the "source of truth" at GitHub.

@Trenly
Copy link
Contributor Author

Trenly commented Dec 20, 2023

If we want to emphasize agreements in the prompts, I think we should modify the ShowPackageAgreements method to show agreements + basic necessary info only, and not reusing the ShowPackageInfo directly. We may add more things to "winget show" for package info in the future, and if we don't remember to treat them separately for ShowAgreementsOnly, it will be shown in ShowPackageAgreements.

Great point; Thanks for the feedback - will update

@Trenly Trenly changed the title Add Switch for showing only agreements during show flow Show only agreement related info during install Dec 20, 2023
Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>
@yao-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit 995a95d into microsoft:master Jan 25, 2024
8 checks passed
@Trenly Trenly deleted the AgreementsOnlySwitch branch January 25, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants