Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings.schema.0.2.json not validating against schema #4200

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Mat2095
Copy link
Contributor

@Mat2095 Mat2095 commented Feb 25, 2024


settings.schema.0.2.json does currently not validate against the JSON 2019-09 schema draft, although it claims it does.
uniqueItems should be a boolean, not a string: https://json-schema.org/draft/2019-09/json-schema-validation#rfc.section.6.4.3
maxLength should be an integer, not a string: https://json-schema.org/draft/2019-09/json-schema-validation#rfc.section.6.3.1
After these changes, it does validate.
Tested before/after with https://www.jsonschemavalidator.net/

Microsoft Reviewers: Open in CodeFlow

@Mat2095 Mat2095 marked this pull request as ready for review February 26, 2024 18:47
@Mat2095
Copy link
Contributor Author

Mat2095 commented Feb 26, 2024

I'm a bit confused about the CLA-signing. When I opend this PR, the check already passed, but I had not signed it yet. I would have expected the bot to ask me to sign it at that point. I later posted another PR on winget-pkgs where I was prompted to sign the CLA, which I did. And right now I ticked the checkbox from the PR-template. Is that how it should go?

@Mat2095 Mat2095 requested a review from a team as a code owner February 26, 2024 18:54
@denelon
Copy link
Contributor

denelon commented Feb 26, 2024

@Mat2095 the WinGet team doesn't manage the CLA signing bot. We've seen a couple of issues in the past. I believe they are all resolved. The checkbox in the template is more of a checklist than an enforcement. The enforcement happens as a part of the automated checks performed when a PR is submitted.

@yao-msft yao-msft merged commit a695aa4 into microsoft:master Feb 26, 2024
4 checks passed
@yao-msft
Copy link
Contributor

yao-msft commented Feb 26, 2024

image
So I assume the CLA requirements are met.

@Mat2095 Mat2095 deleted the patch-1 branch February 26, 2024 23:25
@Mat2095
Copy link
Contributor Author

Mat2095 commented Feb 26, 2024

So I assume the CLA requirements are met.

Yes, I signed it here: microsoft/winget-pkgs#140939 (comment)
The check from your screenshot said that requirements were met even before I signed it, which caused my confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants