Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ignore-warnings to Export command #4214

Closed
wants to merge 2 commits into from

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Feb 29, 2024

Manually validated output files remained the same.


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner February 29, 2024 04:21
@yao-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor

Just leave my thoughts here. In the future, if we want to filter the output, we should do a refactor and do it in reporter level. So we don't need to check every place. Something like Reporter.DisableReportLevel(Level::Warning), then reporter will no longer output for warning level.

@Trenly
Copy link
Contributor Author

Trenly commented Feb 29, 2024

Just leave my thoughts here. In the future, if we want to filter the output, we should do a refactor and do it in reporter level. So we don't need to check every place. Something like Reporter.DisableReportLevel(Level::Warning), then reporter will no longer output for warning level.

Good point; I can try taking a look into that (in a separate PR), though it may be above my skill level

@yao-msft
Copy link
Contributor

Good point; I can try taking a look into that (in a separate PR), though it may be above my skill level

If we can do in the Reporter level, I would discard this pr. This one only disable the warning in this specific workflow task, it will not ignore warnings from previous steps in ExportCommand like HandleSearchResultFailures

And we don't need to do spot checks at multiple places. the code will be cleaner.

@Trenly
Copy link
Contributor Author

Trenly commented Feb 29, 2024

If we can do it at the reporter level, I would revert these changes as part of the PR to handle the reporter refactor, since with that refactor the --ignore-warnings arg should likely be added to the common args list rather than individual commands anyways

I know that there are other areas like ValidateCommand which would also need to be cleaned up anyways

@yao-msft
Copy link
Contributor

If we can do it at the reporter level, I would revert these changes as part of the PR to handle the reporter refactor, since with that refactor the --ignore-warnings arg should likely be added to the common args list rather than individual commands anyways

That's fine too.

@yao-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Feb 29, 2024

Failed ConfigureFromHttpsConfigurationFile [282 ms]
  Error Message:
     Expected: 0
  But was:  1
  Stack Trace:
     at AppInstallerCLIE2ETests.ConfigureCommand.ConfigureFromHttpsConfigurationFile() in D:\a\1\s\src\AppInstallerCLIE2ETests\ConfigureCommand.cs:line 182

@yao-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly Trenly marked this pull request as draft March 1, 2024 02:21
@yao-msft yao-msft closed this in cf597ec Mar 15, 2024
@Trenly Trenly deleted the SuppressExportWarnings branch March 15, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants