-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ignore-warnings to Export command #4214
Conversation
8054634
to
a994052
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Just leave my thoughts here. In the future, if we want to filter the output, we should do a refactor and do it in reporter level. So we don't need to check every place. Something like Reporter.DisableReportLevel(Level::Warning), then reporter will no longer output for warning level. |
Good point; I can try taking a look into that (in a separate PR), though it may be above my skill level |
If we can do in the Reporter level, I would discard this pr. This one only disable the warning in this specific workflow task, it will not ignore warnings from previous steps in ExportCommand like HandleSearchResultFailures And we don't need to do spot checks at multiple places. the code will be cleaner. |
If we can do it at the reporter level, I would revert these changes as part of the PR to handle the reporter refactor, since with that refactor the I know that there are other areas like ValidateCommand which would also need to be cleaned up anyways |
That's fine too. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Manually validated output files remained the same.
Microsoft Reviewers: Open in CodeFlow