Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Repair-WinGetPackageManager with UiXaml 2.8 #4218

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Feb 29, 2024

Fixes an issue with Repair-WinGetPackageManager not installing the correct version of Ui.Xaml (2.8.6) which is required by the latest release (1.7.10582)

Also I checked the commit history and the minimum version that has the update to v2.8.6 for UI.Xaml is our RC candidate 1.7.10514

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner February 29, 2024 19:09
@@ -73,12 +73,12 @@ internal class AppxModuleHelper
private const string VCLibsUWPDesktopArm64 = "https://aka.ms/Microsoft.VCLibs.arm64.14.00.Desktop.appx";

// Xaml
private const string XamlPackage27 = "Microsoft.UI.Xaml.2.7";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just swapping to 2.8 will mean that older versions won't install. I would rather have a fix that handles both situations.

@ryfu-msft ryfu-msft merged commit 464e177 into microsoft:master Mar 1, 2024
8 checks passed
@ryfu-msft ryfu-msft deleted the fixUiXaml branch March 1, 2024 19:40
ryfu-msft added a commit to ryfu-msft/winget-cli that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants