Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicates from MultiQuery #4286

Merged
merged 4 commits into from Mar 22, 2024
Merged

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Mar 19, 2024


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner March 19, 2024 15:47
@yao-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yao-msft
yao-msft previously approved these changes Mar 21, 2024
@Trenly
Copy link
Contributor Author

Trenly commented Mar 21, 2024

I'm hoping this is a transient issue not related to the change?

  Failed ValidateWinGetDscResource_SourceOpenFailed [74 ms]
  Error Message:
     Expected: True
  But was:  False
  Stack Trace:
     at AppInstallerCLIE2ETests.ConfigureValidateCommand.ValidateWinGetDscResource_SourceOpenFailed() in D:\a\1\s\src\AppInstallerCLIE2ETests\ConfigureValidateCommand.cs:line 276
  Standard Output Messages:
 Starting command run. AICLI path: wingetdev.exe Command: configure validate Parameters: D:\a\1\s\src\x86\Release\AppInstallerCLIE2ETests\TestData\Configuration\WinGetDscResourceValidate_SourceOpenFailed.yml Timeout: 120000
 Command run completed with exit code: 1

@yao-msft
Copy link
Contributor

I'm hoping this is a transient issue not related to the change?

  Failed ValidateWinGetDscResource_SourceOpenFailed [74 ms]
  Error Message:
     Expected: True
  But was:  False
  Stack Trace:
     at AppInstallerCLIE2ETests.ConfigureValidateCommand.ValidateWinGetDscResource_SourceOpenFailed() in D:\a\1\s\src\AppInstallerCLIE2ETests\ConfigureValidateCommand.cs:line 276
  Standard Output Messages:
 Starting command run. AICLI path: wingetdev.exe Command: configure validate Parameters: D:\a\1\s\src\x86\Release\AppInstallerCLIE2ETests\TestData\Configuration\WinGetDscResourceValidate_SourceOpenFailed.yml Timeout: 120000
 Command run completed with exit code: 1

Seems like so. All other builds are failing too.

@JohnMcPMS
Copy link
Member

I'm hoping this is a transient issue not related to the change?

  Failed ValidateWinGetDscResource_SourceOpenFailed [74 ms]
  Error Message:
     Expected: True
  But was:  False
  Stack Trace:
     at AppInstallerCLIE2ETests.ConfigureValidateCommand.ValidateWinGetDscResource_SourceOpenFailed() in D:\a\1\s\src\AppInstallerCLIE2ETests\ConfigureValidateCommand.cs:line 276
  Standard Output Messages:
 Starting command run. AICLI path: wingetdev.exe Command: configure validate Parameters: D:\a\1\s\src\x86\Release\AppInstallerCLIE2ETests\TestData\Configuration\WinGetDscResourceValidate_SourceOpenFailed.yml Timeout: 120000
 Command run completed with exit code: 1

Seems like so. All other builds are failing too.

I'm trying to get to the bottom of it, the failing tests seem to always have an exit code of 1 from winget and don't leave any log file to be collected into the artifacts. My server coordination PR is likely to have the fix once it is determined.

@yao-msft
Copy link
Contributor

/azp run

@yao-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit a3bb538 into microsoft:master Mar 22, 2024
8 checks passed
@Trenly Trenly deleted the DedupeArg branch March 22, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winget upgrade allows updating the same package twice
3 participants