Dynamic runtime configuration support #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
Apr 5, 2024
src/AppInstallerCLICore/ConfigurationSetProcessorFactoryRemoting.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerCLICore/ConfigurationSetProcessorFactoryRemoting.cpp
Outdated
Show resolved
Hide resolved
src/Microsoft.Management.Configuration/ConfigurationSetSerializer.cpp
Outdated
Show resolved
Hide resolved
JohnMcPMS
reviewed
Apr 8, 2024
| { | ||
| emitter << AppInstaller::YAML::Key << keyName << AppInstaller::YAML::Value << property.GetInt64(); | ||
| IPropertyValue property = value.try_as<IPropertyValue>(); | ||
| auto type = property.Type(); |
There was a problem hiding this comment.
I don't know how strict ValueSet is at preventing anything that isn't a ValueSet or IPropertyValue from getting in, so this could result in a null dereference. Either change the try_as to just as or check for null and throw.
There was a problem hiding this comment.
Changed IPropertyValue conversion to using as
src/Microsoft.Management.Configuration/ConfigurationSetSerializer.cpp
Outdated
Show resolved
Hide resolved
JohnMcPMS
approved these changes
Apr 8, 2024
yao-msft
pushed a commit
to yao-msft/winget-cli
that referenced
this pull request
Apr 9, 2024
Credit to @JohnMcPMS for initial prototyping. For reference: `DynamicFactory` holds the same integrity level remote factory `DynamicFactory` creates `DynamicSetProcessor`, giving it a copy of the same integrity level remote factory `DynamicSetProcessor` creates more remote factories and remote set processors at other integrity levels as needed `DynamicSetProcessor` uses the appropriate remote set processor to create the unit processor Changes: Added logic to separate out units with high integrity levels and serializing those units into a yaml string. This yaml string will be passed to `CreateOutOfProcessFactory()` along with the json string containing the "path" as the limitation set in the configuration remote server and processors. Tests: I only added one test for verifying serialization and manually verified the json output for `path`. In the interest of time, I created this PR to get out the feature and will continue to work on adding more thorough E2E testing after everything is fully integrated. CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4355) --------- Co-authored-by: John McPherson <johnmcp@microsoft.com>
yao-msft
pushed a commit
that referenced
this pull request
Apr 9, 2024
Credit to @JohnMcPMS for initial prototyping. For reference: `DynamicFactory` holds the same integrity level remote factory `DynamicFactory` creates `DynamicSetProcessor`, giving it a copy of the same integrity level remote factory `DynamicSetProcessor` creates more remote factories and remote set processors at other integrity levels as needed `DynamicSetProcessor` uses the appropriate remote set processor to create the unit processor Changes: Added logic to separate out units with high integrity levels and serializing those units into a yaml string. This yaml string will be passed to `CreateOutOfProcessFactory()` along with the json string containing the "path" as the limitation set in the configuration remote server and processors. Tests: I only added one test for verifying serialization and manually verified the json output for `path`. In the interest of time, I created this PR to get out the feature and will continue to work on adding more thorough E2E testing after everything is fully integrated. CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4355) --------- Co-authored-by: John McPherson <johnmcp@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @JohnMcPMS for initial prototyping.
For reference:
DynamicFactoryholds the same integrity level remote factoryDynamicFactorycreatesDynamicSetProcessor, giving it a copy of the same integrity level remote factoryDynamicSetProcessorcreates more remote factories and remote set processors at other integrity levels as neededDynamicSetProcessoruses the appropriate remote set processor to create the unit processorChanges:
Added logic to separate out units with high integrity levels and serializing those units into a yaml string. This yaml string will be passed to
CreateOutOfProcessFactory()along with the json string containing the "path" as the limitation set in the configuration remote server and processors.Tests:
I only added one test for verifying serialization and manually verified the json output for
path. In the interest of time, I created this PR to get out the feature and will continue to work on adding more thorough E2E testing after everything is fully integrated.Microsoft Reviewers: Open in CodeFlow