Make DLL directory work in packaged cases as well #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrubengu
approved these changes
Apr 19, 2024
msftrubengu
pushed a commit
to msftrubengu/winget-cli
that referenced
this pull request
Apr 23, 2024
## Change Move the code that enables our .winmd to be found by the PS module out of the unpackaged conditional block. It will now be run if we failed to find a result for any reason.
msftrubengu
added a commit
that referenced
this pull request
Apr 23, 2024
#4389 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4401) Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Move the code that enables our .winmd to be found by the PS module out of the unpackaged conditional block. It will now be run if we failed to find a result for any reason.
Validation
Packaged PS from the Store is able to work.
Microsoft Reviewers: Open in CodeFlow