Trim Version When Parsing #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
Jun 14, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnMcPMS
approved these changes
Jun 14, 2024
This was referenced Jun 14, 2024
JohnMcPMS
pushed a commit
that referenced
this pull request
Jun 14, 2024
When creating #4554 I tested that it functioned manually. After the PR merged, however, I figured I should probably add some tests for it. I'm not entirely certain I understand how version parsing truly works, but figured I'd take a stab at making the tests anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a version, it may be possible that a publisher included one or more whitespace characters at the end of the DisplayVersion key. Since a folder name cannot end with a whitespace character, this means that any PackageVersion in the community repository cannot have a trailing whitespace character.
Due to the way versions are parsed, the trailing whitespace gets considered as an "other" of the version part during the version comparison. This means that
5.8is considered a lower version than5.8when parsed.This PR makes it so that when a version is assigned, as is the case when parsing the installed versions, both the final version and the version parts are trimmed of whitespace. This means that
5.0.13is now considered equal to5.0 .13,5.0.13, or even5 . 0 .13Microsoft Reviewers: Open in CodeFlow