Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command: Bad behavior if existing manifest has multiple installer URLs and a URL is provided on cmd-line #15

Closed
palenshus opened this issue May 17, 2021 · 0 comments · Fixed by #55

Comments

@palenshus
Copy link
Contributor

Brief description of your issue

For the Update command, if the existing manifest in winget-pkgs has multiple installer urls, we'll get bad behavior if the URL doesn't specify a URL on the command line.

Steps to reproduce

update -i Microsoft.PowerShell -u https://github.com/PowerShell/PowerShell/releases/download/v7.1.3/PowerShell-7.1.3-win-x64.msi

Expected behavior

Error message indicating that multiple URLs are not supported.

Actual behavior

Update "succeeds" and produces an installer manifest with two nodes with the same URL, but different archs and hashes

@ghost ghost added the Needs-Triage label May 17, 2021
@denelon denelon added this to the v1.0 - `winget create` milestone May 28, 2021
@denelon denelon added this to To do in Create-Bugs Jun 2, 2021
@ghost ghost added the In-PR label Jun 3, 2021
@palenshus palenshus moved this from To do to In progress in Create-Bugs Jun 3, 2021
Create-Bugs automation moved this from In progress to Done Jun 4, 2021
@ghost ghost added Resolution-Fix-Committed and removed In-PR labels Jun 4, 2021
@palenshus palenshus moved this from Done to Released in Create-Bugs Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Create-Bugs
Released
Development

Successfully merging a pull request may close this issue.

2 participants