Calculated installer hash incorrect for sourceforge.net URLs

[chausner]

Brief description of your issue

The installer hash included by the tool is incorrect for download URLs from sourceforge.net. So far for every URL I tried, the hash was incorrect.

Steps to reproduce

Run for example wingetcreate.exe new http://sourceforge.net/projects/ufraw/files/ufraw/ufraw-0.19.2/ufraw-0.19.2-2-setup.exe/download

Expected behavior

The installer hash should be 5BC7A132CA7483AACD09D00AC0D6DDA106D585FE227AF4EF34DABC9EE81A9844. This is also the hash that manifest validation expects, and the hash returned by

$stream = (New-Object System.Net.WebClient).OpenRead($Uri)
Get-FileHash -InputStream $stream -Algorithm SHA256

Actual behavior

The installer hash is incorrectly calculated as 41005A837D2EBF343F851815E0F6CF2BF1A64F58CDEF68D54CE8352F9008F7B7.

Environment

Windows Package Manager Manifest Creator v0.1.0.1

[palenshus]

I'm unable to repro this, when I run wingetcreate.exe new http://sourceforge.net/projects/ufraw/files/ufraw/ufraw-0.19.2/ufraw-0.19.2-2-setup.exe/download locally I get 5BC7A132CA7483AACD09D00AC0D6DDA106D585FE227AF4EF34DABC9EE81A9844 as the InstallerSha256. I wonder if you have a bad local cached copy of the installer in %temp%, can you check and delete it if found, then try again? If that's the issue, then #56 should fix it

[chausner]

Thanks for the hint. Yes, I can confirm that by deleting %temp%\download the issue is fixed. It seems I ran into a variant of #40 because all sourceforge.net URLs end with /download so the same temporary file name was being used for different downloads.

[palenshus]

Ah, thanks for checking! We'll have a new release with the fix very soon