Clean up temp files from installer download

[ryfu-msft]

The changes in this pull request ensure that the temp files from the downloaded installer are deleted before the end of the command execution. This should fix #40, where the installer hash does not match due to old installer files not being cleaned up from the %TEMP% directory.

Microsoft Reviewers: Open in CodeFlow

[palenshus]

Looks like we have a bug, in DownloadFileAsync, if the file already exists, but with a different length, we download the new one, but looks like that doesn't replace the old one, it just writes overwrites it. Meaning, if the previous one is larger, we'll download a smaller one and write those bytes over the old one, creating a bogus file.

The fix is simple, and I think sufficient to protect us here, add a File.Delete:

        if (!File.Exists(targetFile) || new FileInfo(targetFile).Length != downloadSize)
        {
            File.Delete(targetFile);
            using var targetFileStream = File.OpenWrite(targetFile);

What do you think?

[ryfu-msft]

Looks like we have a bug, in DownloadFileAsync, if the file already exists, but with a different length, we download the new one, but looks like that doesn't replace the old one, it just writes overwrites it. Meaning, if the previous one is larger, we'll download a smaller one and write those bytes over the old one, creating a bogus file.

The fix is simple, and I think sufficient to protect us here, add a File.Delete:

        if (!File.Exists(targetFile) || new FileInfo(targetFile).Length != downloadSize)
        {
            File.Delete(targetFile);
            using var targetFileStream = File.OpenWrite(targetFile);

What do you think?

100% agree. This is a much better solution. I added your suggested changes and removed mine

[palenshus]

using CommandLine;

Can you reset this file since it's no longer being changed?

---

Refers to: src/WingetCreateCLI/Commands/NewCommand.cs:13 in 9c904ab. [](commit_id = 9c904ab, deletion_comment = False)

[palenshus]