Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation pipeline failed on manifest determined valid by client #128

Closed
denelon opened this issue May 15, 2020 · 4 comments
Closed

Validation pipeline failed on manifest determined valid by client #128

denelon opened this issue May 15, 2020 · 4 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone
v1.0 - Packages

Comments

@denelon
Copy link
Contributor

denelon commented May 15, 2020

PR #123 manifest passed validation on client version v0.1.41331 Preview, but the validation pipeline failed the PR.
@sob
Copy link
Contributor

sob commented May 15, 2020

I noticed this when adding the ManifestVersion key to a manifest file. Passes validation by the client but fails in the PR validation.

@denelon
Copy link
Contributor Author

denelon commented May 16, 2020

The first instance of this issue was related to multiple installers in a single manifest.

@denelon
Copy link
Contributor Author

denelon commented May 16, 2020

The ManifestVersion key wasn't ready for the release when the second issue was identified.

@denelon denelon pinned this issue May 16, 2020
@denelon denelon added this to the Packages Backlog milestone Jun 3, 2020
@denelon denelon added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 28, 2020
@hchorey hchorey mentioned this issue Sep 3, 2020
Closed
4 tasks
@denelon denelon unpinned this issue Oct 8, 2020
@denelon
Copy link
Contributor Author

denelon commented Jan 6, 2021

This should be resolved now.

@denelon denelon closed this as completed Jan 6, 2021
seejdev pushed a commit to seejdev/winget-pkgs that referenced this issue Nov 4, 2021
@denelon
making Bug Report (microsoft#128)
75074e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
v1.0 - Packages
Development

No branches or pull requests
2 participants
@sob @denelon