Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Request]: WinSSHTerm metadata is incomplete and does not allow for machine wide installations #158024

Closed
dnnnp opened this issue Jun 16, 2024 · 2 comments · Fixed by #158047
Labels
Package-Update This package needs to be updated
Milestone

Comments

@dnnnp
Copy link

dnnnp commented Jun 16, 2024

What type of update are you requesting?

A new locale, architecture, or installer type of an existing version

Current Package Identifier

P-StSoftware.WinSSHTerm

Package Version

2.35.2

Please describe the changes you would like to see

The metadata for WinSSHTerm is incomplete and does not allow for machine wide installations.

Issuing the command winget install P-StSoftware.WinSSHTerm --scope machine yields the following error:

No applicable installer found; see logs for more details.

The error log contains the following hint:

2024-06-16 04:53:31.803 [CLI ] Installer [X64,wix,Unknown,en-US] not applicable: Installer scope does not match required scope: Unknown != Machine
@dnnnp dnnnp added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Jun 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jun 16, 2024
dnnnp added a commit to dnnnp/winget-pkgs that referenced this issue Jun 16, 2024
Specify user scope for existing installers (which is
the default installer scope for WinSSHTerm) and
duplicate installer entries for machine wide scope
with the required InstallerSwitches.
@dnnnp
Copy link
Author

dnnnp commented Jun 16, 2024

Hello, unfortunately I have no idea on how to proceed from here. Every attempt in validating the manifest files via winget validate fails. Implementing the changes within dnnnp@3739c58 directly into the merged manifest works flawlessly for me.

Can anyone point me into the right direction?

@Dragon1573
Copy link
Contributor

Dragon1573 commented Jun 17, 2024

I'm working on it with version v2.35.2.

For validating manifests in the case of this issue, you should run winget validate manifests/p/P-STSoftware/WinSSHTerm/2.35.2/. "Manifest" here is the entire directory of that exact version.

For local validation, you can also run Tools/SandboxTest.ps1 manifests/p/P-STSoftware/WinSSHTerm/2.35.2/ -WingetOptions '--scope machine' for both validating the manifests and try to install the package in Windows Sandbox.

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Triage This work item needs to be triaged by a member of the core team. Help-Wanted This is a good candidate work item from the community. labels Jun 17, 2024
@denelon denelon added this to the 1.8 Packages milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package-Update This package needs to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants