Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: TomHudson.gron version 0.7.1 #107908

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented May 23, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?
Microsoft Reviewers: Open in CodeFlow

image

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mloskot added a commit to mloskot/gron that referenced this pull request May 23, 2023
This change depends on approval and merging of
microsoft/winget-pkgs#107908
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 23, 2023
@microsoft-github-policy-service
Copy link
Contributor

mloskot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit cba3f19 into microsoft:master May 24, 2023
7 checks passed
@microsoft-github-policy-service
Copy link
Contributor

Hello mloskot,
Validation has completed.

Template: msftbot/validationCompleted

@stephengillie
Copy link
Collaborator

This package is an interactive console - entering ["Hello","World","Test"] gave:

json = [];
json[0] = "Hello";
json[1] = "World";
json[2] = "Test";

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@mloskot mloskot deleted the TomHudson.gron-0.7.1-7C125A3760C93B branch May 24, 2023 06:26
@mloskot
Copy link
Contributor Author

mloskot commented May 24, 2023

@stephengillie

This package is an interactive console (...)

Does such package need any special handling, flagging in the manifests that I perhaps have missed?

AFAICT, gron offers both modes w/ interactive console one in case of there is no command line input provided:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants