Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: twpayne.chezmoi version 2.34.3 #111215

Merged
merged 2 commits into from Jul 4, 2023
Merged

New version: twpayne.chezmoi version 2.34.3 #111215

merged 2 commits into from Jul 4, 2023

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Jul 3, 2023 •
edited by microsoft-github-policy-service bot

Pull request has been created with WinGet Releaser v2 🚀

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111215&drop=dogfoodAlpha

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jul 3, 2023
@stephengillie
Copy link
Collaborator

Manual Validation failed with:

5:32:57 PM: C:\Users\User\AppData\Local\Microsoft\WinGet\Links\chezmoi.exe start-process : This command cannot be run due to the error: The specified executable is not a valid application for this OS platform..

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jul 4, 2023
@twpayne twpayne mentioned this pull request Jul 4, 2023
Closed
1 task
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Needs-Author-Feedback This needs a response from the author. labels Jul 4, 2023
twpayne
twpayne commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I've fixed the URLs and checksums.

In the future I'll switch to goreleaser (refs twpayne/chezmoi#3059) as this is likely more reliable than vedantmgoyal2009/winget-releaser.

manifests/t/twpayne/chezmoi/2.34.3/twpayne.chezmoi.installer.yaml Outdated Show resolved Hide resolved
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

twpayne,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello twpayne,
Validation has completed.

Template: msftbot/validationCompleted

@mdanish-kh
Copy link
Contributor

@twpayne Please mark the above conversations as "resolved" to let this PR get merged through the auto-merge process

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello twpayne,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 58be506 into microsoft:master Jul 4, 2023
7 checks passed
@russellbanks
Copy link
Contributor

russellbanks commented Jul 4, 2023 •
edited

likely more reliable than vedantmgoyal2009/winget-releaser.

Sorry about the recent issues @twpayne. I'm a sole developer on Komac so edge cases or odd issues are hard to spot on my own.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@twpayne
Copy link
Contributor Author

twpayne commented Jul 5, 2023

Sorry about the recent issues @twpayne. I'm a sole developer on Komac so edge cases or odd issues are hard to spot on my own.

As I understand it, you fixed Komac quickly. I'm more unsure of vedantmgoyal2009/winget-releaser as winget-releaser seems to lack tests and a release process.

@twpayne twpayne deleted the twpayne.chezmoi-2.34.3-722F4A2A5690523FF73A7843A7DC4922E0965E65 branch July 5, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie left review comments

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service approved these changes

@mdanish-kh mdanish-kh mdanish-kh approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@twpayne @wingetbot @stephengillie @mdanish-kh @russellbanks @yao-msft