Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: MillerPuckette.PureData version 0.54-0 #111566

Conversation

Lucarda
Copy link
Contributor

@Lucarda Lucarda commented Jul 7, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111566&drop=dogfoodAlpha

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 111566 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 111566 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Lucarda
Copy link
Contributor Author

Lucarda commented Jul 7, 2023

@microsoft-github-policy-service agree

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jul 7, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @Lucarda,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@stephengillie
Copy link
Collaborator

The silent installer switches aren't resulting in an unattended installation:
image

@stephengillie
Copy link
Collaborator

Hi @Lucarda,

Does this package have silent installer switches? The installer doesn't respond to common query switches like /?.

@Lucarda
Copy link
Contributor Author

Lucarda commented Jul 7, 2023

Hi @stephengillie

thanks for the contact :)

I think i introduced the bug here

https://github.com/pure-data/pure-data/blob/master/msw/pd.nsi?plain=1#L85-L88

which forces the installer to be interactive. I'll move away the call SetSilent normal from the !macro ONINIT function.

until there's a fix for that I won't make a new PR.

at least this is what i think is failing.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 7, 2023
@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 7, 2023
@Lucarda
Copy link
Contributor Author

Lucarda commented Jul 7, 2023

i'm closing this one until i got the fix on upstream.

thanks.

@Lucarda Lucarda closed this Jul 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants