Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Oracle.JDK.17 version 17.0.8 #112813

Merged
merged 2 commits into from
Jul 24, 2023
Merged

New version: Oracle.JDK.17 version 17.0.8 #112813

merged 2 commits into from
Jul 24, 2023

Conversation

jacobgelling
Copy link
Contributor

@jacobgelling jacobgelling commented Jul 22, 2023 •
edited by microsoft-github-policy-service bot
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/112813&drop=dogfoodAlpha

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 22, 2023
@microsoft-github-policy-service
Copy link
Contributor

jacobgelling,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

mdanish-kh
mdanish-kh suggested changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After committing the suggested changes, you would also have to rename the version folder to match the new PackageVersion. The folder under manifests/o/Oracle/JDK/17 should be renamed from 17.0.8 -> 17.0.8.0

A quick and easy way to do this would be here in GitHub Web by pressing the . (dot) key on your keyboard that'll open up the PR in VS Code Online. Navigate to Explorer menu, find the required folder and make the appropriate rename changes.

After that, stage and commit your changes from Source Control menu on the left. (The changes are automatically pushed)

manifests/o/Oracle/JDK/17/17.0.8/Oracle.JDK.17.installer.yaml Outdated Show resolved Hide resolved
manifests/o/Oracle/JDK/17/17.0.8/Oracle.JDK.17.locale.en-US.yaml Outdated Show resolved Hide resolved
manifests/o/Oracle/JDK/17/17.0.8/Oracle.JDK.17.yaml Outdated Show resolved Hide resolved
manifests/o/Oracle/JDK/17/17.0.8/Oracle.JDK.17.installer.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service
Copy link
Contributor

Hello @jacobgelling,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jul 23, 2023
auto-merge was automatically disabled July 23, 2023 19:31

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 112813 in repo microsoft/winget-pkgs

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 23, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jul 23, 2023
@azure-pipelines
Copy link

No commit pushedDate could be found for PR 112813 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 23, 2023
@mdanish-kh
Copy link
Contributor

@jacobgelling Please mark the above conversations as "resolved" for auto-merge process to merge this PR after the pipeline checks pass

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 23, 2023
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 24, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello jacobgelling,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 24, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello jacobgelling,
Validation has completed.

Template: msftbot/validationCompleted

@jacobgelling jacobgelling mentioned this pull request Jul 24, 2023
Open
2 tasks
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 24, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello jacobgelling,
Validation has completed.

Template: msftbot/validationCompleted

@mdanish-kh
Copy link
Contributor

@jacobgelling Please mark the above conversations as "resolved" for auto-merge process to merge this PR after the pipeline checks pass

cc @jacobgelling

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 24, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello jacobgelling,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4ed9a2f into microsoft:master Jul 24, 2023
7 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service approved these changes

@mdanish-kh mdanish-kh mdanish-kh approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobgelling @wingetbot @mdanish-kh