Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Gloo.cli version 0.1.6 #118856

Conversation

aaronvg
Copy link

@aaronvg aaronvg commented Sep 4, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Sep 4, 2023
@stephengillie stephengillie added the Needs-CLA The author needs to sign the CLA label Sep 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @aaronvg,

This PR cannot be merged until you sign the Contributor License Agreement (CLA). More information on this process can be found on the Microsoft Open Source website.

Template: msftbot/needsCLA

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (The specified executable is not a valid application for this OS platform.) ---
System.ComponentModel.Win32Exception (216): The specified executable is not a valid application for this OS platform.
--- End of stack trace from previous location where exception was thrown --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)

Commands:
- gloo
Installers:
- Architecture: x86
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Architecture: x86
- Architecture: x64

x86 validations are performed on a 32-bit OS. This package installs successfully in a 64-bit VM.

@stephengillie
Copy link
Collaborator

Hi @aaronvg,

This package has a dependency on the VCRedist package:
image

@microsoft-github-policy-service
Copy link
Contributor

Hello @aaronvg,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Sep 5, 2023
@stephengillie stephengillie removed the Blocking-Issue Manifest validation is blocked by a known issue. label Nov 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Nov 21, 2023
Copy link
Contributor

Hello @aaronvg,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Needs-Author-Feedback This needs a response from the author. Needs-CLA The author needs to sign the CLA No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants