Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle.MySQLWorkbench version 8.0.34 #119555

Conversation

optsing
Copy link
Contributor

@optsing optsing commented Sep 13, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

Hello @optsing,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Sep 20, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @optsing,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@optsing
Copy link
Contributor Author

optsing commented Sep 20, 2023

Published too early, PR requires a working Dependencies feature, what will happen with the 1.6 release.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels Sep 20, 2023
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-09-13 09:47:55.379 [CLI ] ShellExecute installer failed: 1603 Property(S): ErrorDialog = SetupErrorDialog
MSI (s) (B4:BC) [09:47:55:062]: Product: MySQL Workbench 8.0 CE -- Installation operation failed.
MSI (s) (B4:BC) [09:47:55:062]: Windows Installer installed the product. Product Name: MySQL Workbench 8.0 CE. Product Version: 8.0.34. Product Language: 1033. Manufacturer: Oracle Corporation. Installation success or error status: 1603.

Yes, 1603 often indicates a missing dependency.

@stephengillie
Copy link
Collaborator

This installs and launches normally in a Windows 10 VM.

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Shell-Execute

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Shell-Execute labels Sep 20, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 20, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @optsing,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@microsoft-github-policy-service
Copy link
Contributor

Hello @optsing,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Sep 20, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 20, 2023
@stephengillie
Copy link
Collaborator

I applied the waiver in error. I assumed that this PR was updating an extant manifest. We'll be accepting new packages with dependencies soon, after the upcoming 1.6 release.

@stephengillie stephengillie removed the Needs-Author-Feedback This needs a response from the author. label Sep 20, 2023
@Trenly
Copy link
Contributor

Trenly commented Dec 13, 2023

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Validation-Shell-Execute labels Dec 13, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 24f3173 into microsoft:master Dec 13, 2023
7 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants