-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: atrenton.MyJournal.Notebook version 16.4.0 #121043
Closed
atrenton
wants to merge
2
commits into
microsoft:master
from
atrenton:atrenton.MyJournal.Notebook-16.4.0-74c17eef-0cfd-4a8f-87e6-0c81543f13a9
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17
manifests/a/atrenton/MyJournal/Notebook/16.4.0/atrenton.MyJournal.Notebook.installer.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Created using wingetcreate 1.5.3.0 | ||
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.5.0.schema.json | ||
|
||
PackageIdentifier: atrenton.MyJournal.Notebook | ||
PackageVersion: 16.4.0 | ||
InstallerType: burn | ||
Installers: | ||
- Architecture: x86 | ||
InstallerUrl: https://github.com/atrenton/MyJournal.Notebook/releases/download/v16.4.0/MyJournal.Notebook.Setup_16.4.0+g51ecde2.exe | ||
InstallerSha256: 07954D492C85628A88F0F1027B5CB46ED911D765EFACA0A2FB74C1A4CC3F0DD5 | ||
Dependencies: | ||
PackageDependencies: | ||
- PackageIdentifier: Microsoft.DotNet.DesktopRuntime.6 | ||
MinimumVersion: 6.0.21 | ||
- PackageIdentifier: XPFFZHVGQWWLHB | ||
ManifestType: installer | ||
ManifestVersion: 1.5.0 |
13 changes: 13 additions & 0 deletions
13
manifests/a/atrenton/MyJournal/Notebook/16.4.0/atrenton.MyJournal.Notebook.locale.en-US.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Created using wingetcreate 1.5.3.0 | ||
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.5.0.schema.json | ||
|
||
PackageIdentifier: atrenton.MyJournal.Notebook | ||
PackageVersion: 16.4.0 | ||
PackageLocale: en-US | ||
Publisher: Art Trenton | ||
PackageName: My Journal Add-In for Microsoft OneNote | ||
License: Microsoft Public License (MS-PL) | ||
Copyright: Copyright (c) Art Trenton. All rights reserved. | ||
ShortDescription: My Journal Add-In for Microsoft OneNote | ||
ManifestType: defaultLocale | ||
ManifestVersion: 1.5.0 |
8 changes: 8 additions & 0 deletions
8
manifests/a/atrenton/MyJournal/Notebook/16.4.0/atrenton.MyJournal.Notebook.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Created using wingetcreate 1.5.3.0 | ||
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.5.0.schema.json | ||
|
||
PackageIdentifier: atrenton.MyJournal.Notebook | ||
PackageVersion: 16.4.0 | ||
DefaultLocale: en-US | ||
ManifestType: version | ||
ManifestVersion: 1.5.0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that
Microsoft.Office
containsOneNote
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed an updated installer manifest with the necessary dependencies. It still fails validation but does install successfully. Need 'Waived-Validation-Shell-Execute' label.
FIRST INSTALLATION TEST RESULTS:
The following dialog is displayed, as my PC is currently configured to only install apps from the Microsoft Store:
![image](https://private-user-images.githubusercontent.com/48064181/272680301-bc4f568c-60a0-4406-aa7c-abcf9297fdb5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1Nzg4NDIsIm5iZiI6MTcyMDU3ODU0MiwicGF0aCI6Ii80ODA2NDE4MS8yNzI2ODAzMDEtYmM0ZjU2OGMtNjBhMC00NDA2LWFhN2MtYWJjZjkyOTdmZGI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyMjkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZmMmEwOTVjZDFmMzFmMjY4ODkyZWVjZjM1OWJmYzNkMmFkY2RiNzEwYzg1NjY4NmU5NTBhNWEyNGE5MDY4MDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wKugK9aqfGFWoZ_6s0B_uK57FZWn4lqlsTaZ-PQKRhw)
CHANGED APP RECOMMENDATION SETTINGS
Settings > Apps > Advanced app settings > Choose where to get apps >
DEFAULT: The Microsoft Store only (Recommended)
CHANGED TO: Anywhere, but warn me before installing an app that's not from the Microsoft Store
SECOND INSTALLATION TEST RESULTS ARE SUCCESSFUL
![image](https://private-user-images.githubusercontent.com/48064181/272681249-574d350e-cced-4f42-b719-e890ef8685b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1Nzg4NDIsIm5iZiI6MTcyMDU3ODU0MiwicGF0aCI6Ii80ODA2NDE4MS8yNzI2ODEyNDktNTc0ZDM1MGUtY2NlZC00ZjQyLWI3MTktZTg5MGVmODY4NWI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyMjkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJhNWJiNWRjMThjZDc0OGRmNGIzY2U2MmJlN2JhOWQ2NjVhMWVjYTViNTljNGM2M2JlMmJlMzkxOTk1ZTY5YmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QhoN2peACeiaB4BqH0OF0IGDH5PGNsZUx95cbuxFxKU)
![image](https://private-user-images.githubusercontent.com/48064181/272681877-b0019d7a-84ec-468f-9dbe-e055f988a491.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1Nzg4NDIsIm5iZiI6MTcyMDU3ODU0MiwicGF0aCI6Ii80ODA2NDE4MS8yNzI2ODE4NzctYjAwMTlkN2EtODRlYy00NjhmLTlkYmUtZTA1NWY5ODhhNDkxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyMjkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYwZDA4NTYyYTZmOGMzZjRlNGM5NDk3ZjY3OGZmMTg5Yzc1OTc0ODdhNGJkMTk1ZmYwOWQxZDYyMWY1NTMxOTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rF6K3Q8JYYCNsynXCPtTa32voYbFy4E9p4ZuNW1z3x4)
The following dialog is displayed:
Clicked the Run anyway button, as the code is signed by me.
The next dialog is a warning:
Clicked the Install anyway button.
CONSOLE OUTPUT