Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows terminal quake v1.6 #124182

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Windows terminal quake v1.6 #124182

merged 6 commits into from
Jan 4, 2024

Conversation

flyingpie
Copy link
Contributor

@flyingpie flyingpie commented Oct 29, 2023 •
edited

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@flyingpie flyingpie mentioned this pull request Oct 29, 2023
Closed
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Oct 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 29, 2023
@flyingpie
Copy link
Contributor Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 29, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 29, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Oct 29, 2023
@stephengillie
Copy link
Collaborator

Hi @flyingpie,

Microsoft.WindowsTerminal appears to be a dependency:
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Nov 2, 2023
auto-merge was automatically disabled November 2, 2023 23:35

Head branch was pushed to by a user without write access

@flyingpie @stephengillie
Update manifests/f/flyingpie/windows-terminal-quake/1.6/flyingpie.win…
2637ca5 
…dows-terminal-quake.installer.yaml

Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 23, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Nov 23, 2023
@stephengillie
Copy link
Collaborator

@stephengillie stephengillie added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 5, 2023
@flyingpie
Copy link
Contributor Author

Although the app works along side Windows Terminal, people can also install Terminal through other means.

Could we go with a version for now that does not have Windows Terminal as a dependency?

There might be a version in the future that works with other terminals even, so it could be considered more "correct" anyway.

@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 3, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 3, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

flyingpie,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@stephengillie
Copy link
Collaborator

If I'm understanding correctly, this is normal program operation.
image

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit c74ce7d into microsoft:master Jan 4, 2024
13 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 4, 2024
@flyingpie flyingpie deleted the windows-terminal-quake-v16 branch February 10, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@flyingpie @wingetbot @stephengillie @zachcarp @hackean-msft @Madhusudhan-MSFT @ryfu-msft