Add portable installers to Coder 2.4.0 #129175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mdanish-kh
changed the title
matifali
reviewed
Dec 4, 2023
matifali
reviewed
Dec 4, 2023
wingetbot
added
Azure-Pipeline-Passed
stephengillie
approved these changes
Dec 5, 2023
microsoft-github-policy-service
bot
added
the
Moderator-Approved
microsoft-github-policy-service
bot
merged commit a011bc5
into
microsoft:master
7 checks passed
![microsoft-github-policy-service[bot]](https://avatars.githubusercontent.com/in/95686?s=60&v=4){kind=small}
|
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
matifali
added a commit
to coder/coder
that referenced
this pull request
Dec 5, 2023
This PR updates `release.yaml` workflow to automate updates for `arm64` and `x64` zip installers to winget. This has recently been merged into [winget](microsoft/winget-pkgs#129175). Thanks to @mdanish-kh for the upstream PR.
matifali
added a commit
to coder/coder
that referenced
this pull request
Dec 5, 2023
* ci: add arm64 and amd64 portable binaries to winget This PR updates `release.yaml` workflow to automate updates for `arm64` and `x64` zip installers to winget. This has recently been merged into [winget](microsoft/winget-pkgs#129175). Thanks to @mdanish-kh for the upstream PR. * fixup! * remove extra `--urls` flags * remove architecture override. `wingetcreate` does not need architecture override as it now supports parsing the URL for `amd64` and correctly marking it as x64 architecture. Reference: 1. https://github.com/microsoft/winget-create/blob/08baf0e61e62dabcb2487397984fc69fad6a7499/src/WingetCreateCore/Common/PackageParser.cs#L594C56-L594C61 2. PR: microsoft/winget-create#445 2. This has been available since version https://github.com/microsoft/winget-create/releases/tag/v1.5.3.0 * fixup! * Update release.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow