Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YamlCreate] Read PFN from MSIX/APPX/Bundle without installing #129186

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Dec 4, 2023

This PR changes the logic for fetching PackageFamilyName so that instead of installing the package or bundle, it will convert the file to a Zip, extract the AppxManifest or AppxBundleManifest, and calculate the PFN. I decided to not remove the prompt asking if users wanted to detect automatically because I felt it could break some users if they were using YamlCreate in an automated way.

cc @russelbanks @mdanish-kh @OfficialEsco

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An enhancement would be to make the flow similar to how we get ProductCode from MSI, i.e., fetch it automatically and show it to user (and ask if the user wants to enter a manual PackageFamilyName). Other than that the changes look good

image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 4, 2023
@Trenly
Copy link
Contributor Author

Trenly commented Dec 4, 2023

An enhancement would be to make the flow similar to how we get ProductCode from MSI, i.e., fetch it automatically and show it to user (and ask if the user wants to enter a manual PackageFamilyName).

I considered this, but I didn't want to break any scripts or automations that were expecting the Y/N prompt. Unless you think it isn't a breaking change? I just figured better to be safe about it

@mdanish-kh
Copy link
Contributor

Ah, I see. I agree with the safer approach.

@denelon denelon merged commit 510c650 into microsoft:master Dec 5, 2023
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 5, 2023
@Trenly Trenly deleted the PFNDetection branch December 5, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File
Projects
None yet
6 participants