Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VCLibs Hash for SandboxTest.ps1 #136894

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Update VCLibs Hash for SandboxTest.ps1 #136894

merged 1 commit into from
Jan 29, 2024

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jan 28, 2024 •
edited by microsoft-github-policy-service bot

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 28, 2024
@stephengillie stephengillie merged commit aa463fb into microsoft:master Jan 29, 2024
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot added Moderator-Approved One of the Moderators has reviewed and approved this PR and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 29, 2024
@stephengillie
Copy link
Collaborator

Should this be made dynamic in some way? Possibly through checking the latest manifest?

@Trenly Trenly deleted the FixSandboxHash branch January 29, 2024 16:13
@Trenly
Copy link
Contributor Author

Trenly commented Jan 29, 2024 •
edited

Should this be made dynamic in some way? Possibly through checking the latest manifest?

Possibly; We could omit the hash entirely, but then we would be relying on the assumption that there hasn’t been a compromise of the CDN, aka.ms link, or any of the domain controllers along the way.

One other option I can look into is installing the winget PowerShell cmdlets and then calling the function to repair winget, which, in theory, should boostrap everything needed, but it would then make the WinGet version selection much more difficult to implement

@Trenly Trenly mentioned this pull request Jan 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Trenly @wingetbot @stephengillie