Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GorillaDevs.Ferium version 4.5.2 #140834

Merged

Conversation

theRookieCoder
Copy link
Contributor

@theRookieCoder theRookieCoder commented Feb 24, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@theRookieCoder
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Feb 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 24, 2024
@theRookieCoder
Copy link
Contributor Author

I'm getting issues with windows defender locally too. After whitelisting the file I'm able to install it and it works fine.

@theRookieCoder theRookieCoder marked this pull request as ready for review February 24, 2024 08:57
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 24, 2024
@stephengillie
Copy link
Collaborator

Hi @theRookieCoder,

The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.

(Automated response - build 821.)

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335187 2024-02-24 00:51:53.272 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.5.2/ferium-windows-msvc.zip Result: 0x80004005 2024-02-24 00:51:53.272 [CLI ] Terminating context: 0x8a15002d at D:\a_work\1\s\external\pkg\src\AppInstallerCLICore\Workflows\DownloadFlow.cpp:1e6

(Automated response - build 821.)

@stephengillie
Copy link
Collaborator

@wingetbot run

3 similar comments
@stephengillie
Copy link
Collaborator

@wingetbot run

@stephengillie
Copy link
Collaborator

@wingetbot run

@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Validation-Defender-Error Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 1, 2024
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Mar 1, 2024
@theRookieCoder
Copy link
Contributor Author

I would like to get some help from moderation here. Firstly, this isn't a new manifest, this is an update of an existing one (have I configured something wrong?)

I also have no idea how I can resolve the validation error because it is a false positive by Windows Defender. I have already reported the false positive to Microsoft directly and have had no response.
Previous PRs (#139278 and #137742) had the same issue and the validation error was waived. Can I request the same to be done here?

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\GorillaDevs.Ferium__DefaultSource\ferium.exe returned exit code: 2
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\ferium.exe returned exit code: 2

(Automated response - build 858.)

@stephengillie
Copy link
Collaborator

Hi @theRookieCoder.

Thanks for opening a PR.

I would like to get some help from moderation here. Firstly, this isn't a new manifest, this is an update of an existing one (have I configured something wrong?)

Each PR containing a manifest is automatically processed by our GitHub Actions into an Azure DevOps pipeline run, where the package described in the manifest is installed and scanned. The goal of this is to greatly limit the installation of compromised or otherwise potentially unwanted software (PUA).

I also have no idea how I can resolve the validation error because it is a false positive by Windows Defender.

It's subtle, but the error changed from Installation to Executable. On the latest run, it wasn't blocked by Defender. The package installed normally and launched, but gave a non-zero exit code. Sometimes, it takes the Defender teams a few hours to a few days to clear a false positive.

Previous PRs (#139278 and #137742) had the same issue and the validation error was waived. Can I request the same to be done here?

Yes, we can apply a waiver for now. Eventually, can the exit code be changed to a 0?

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Mar 4, 2024
@theRookieCoder
Copy link
Contributor Author

theRookieCoder commented Mar 4, 2024

Thanks for the feedback!

The package installed normally and launched, but gave a non-zero exit code

This is a CLI application, so it expects some sort of subcommand or argument to be provided. Is there a way to tell the CI to check the version (run ferium -V) or something infallible like that to result in a non-zero error code?

@stephengillie
Copy link
Collaborator

From the schema, there are 2 options here:

  • Commands: - I haven't seen a PR using these, so I'm not sure of the impact. In theory, switches (such as -V in your example above) are put here.
  • ExpectedReturnCodes or similar - Putting 2 here might be the best option.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b2859f4 into microsoft:master Mar 4, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 4, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants