Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Oven-sh.Bun version 1.1.0 #147222

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Apr 1, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sitiom
Copy link
Contributor

sitiom commented Apr 1, 2024

Copy link
Contributor

@sitiom sitiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by @paperdave, a CPU check like this would be nice, but I guess it's not possible with Winget yet:

if (-not (Add-Type -MemberDefinition '[DllImport("kernel32.dll")] public static extern bool IsProcessorFeaturePresent(int ProcessorFeature);'-Name 'Kernel32'-Namespace 'Win32'-PassThru)::IsProcessorFeaturePresent(40)) {
    Write-Host -Foreground Red "This CPU does not support the AVX2 instruction set. Please install 'Oven-sh.Bun.Baseline' instead."
}

@sitiom sitiom mentioned this pull request Apr 1, 2024
@mdanish-kh
Copy link
Contributor Author

As suggested by @paperdave, a CPU check like this would be nice, but I guess it's not possible with Winget yet:

if (-not (Add-Type -MemberDefinition '[DllImport("kernel32.dll")] public static extern bool IsProcessorFeaturePresent(int ProcessorFeature);'-Name 'Kernel32'-Namespace 'Win32'-PassThru)::IsProcessorFeaturePresent(40)) {
    Write-Host -Foreground Red "This CPU does not support the AVX2 instruction set. Please install 'Oven-sh.Bun.Baseline' instead."
}

Yes, I don't think that's possible with WinGet. We can have a note printed out after installation though that says something like:

If you face issues running the package, it might be because your CPU does not support AVX2 instruction set. In that case, try installing Over-sh.Bun.Baseline instead.

Co-authored-by: sitiom <sitiom@proton.me>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested New-Package labels Apr 1, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 1, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f6e3a56 into microsoft:master Apr 1, 2024
8 checks passed
@mdanish-kh mdanish-kh deleted the Oven-sh.Bun-1.1.0-af932f08-5b30-49db-a2d0-c11d92318bc3 branch April 1, 2024 19:38
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

NestedInstallerType: portable
NestedInstallerFiles:
- RelativeFilePath: bun-windows-x64\bun.exe
PortableCommandAlias: bun
Copy link
Contributor

@sitiom sitiom Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this too, a bunx alias for bun x (Bun automatically detects the naming):

Suggested change
PortableCommandAlias: bun
PortableCommandAlias: bun
- RelativeFilePath: .\bun-windows-x64\bun.exe
PortableCommandAlias: bunx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants