Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Gyan.FFmpeg version 7.0 #147886

Merged

Conversation

aisgbnok
Copy link
Contributor

@aisgbnok aisgbnok commented Apr 5, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 5, 2024
@stephengillie
Copy link
Collaborator

Hi @aisgbnok,

This PR's version number 7.0 has 2 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 6.1.1, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)

(Automated response - build 876)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. labels Apr 5, 2024
auto-merge was automatically disabled April 5, 2024 15:18

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. New-Manifest Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. labels Apr 5, 2024
@aisgbnok
Copy link
Contributor Author

aisgbnok commented Apr 5, 2024

Hey @stephengillie,

This is a portable installer, so the executable does not place an entry in Windows settings. WinGet seems to do that based on the reported version number in the manifest.
image

However, I am confident 7.0 is the correct version. The executable reports version 7.0, and that is what the author uses.
image

This reduction in parameters is not new for Gyan.FFmpeg in the winget-pkgs repository. For example, 5.0 -> 5.0.1 -> 5.1, etc.

This applies to #147884 and #147887 as well.

@stephengillie
Copy link
Collaborator

Verify:
image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 5, 2024
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b36c1a9 into microsoft:master Apr 5, 2024
8 checks passed
@aisgbnok aisgbnok deleted the ffmpeg-7.0-full branch April 5, 2024 16:28
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@stephengillie
Copy link
Collaborator

This reduction in parameters is not new for Gyan.FFmpeg in the winget-pkgs repository. For example, 5.0 -> 5.0.1 -> 5.1, etc.

Thanks for letting me know. I'll add it to an exception list for this check. (Currently manual, might be noisy until it's fully automated.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants