Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert manifest to actual version number Microsoft.Office 16.0.17425.20176 #150300

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

treysis
Copy link
Contributor

@treysis treysis commented Apr 20, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


The previous update to the manifest contains the wrong version number. That version number is just for the Deployment Tool.

The current version for Microsoft 365 is still 16.0.17425.20176, also as per the official version information page:
https://learn.microsoft.com/en-us/officeupdates/update-history-microsoft365-apps-by-date

The Office Deployment Tool uses a similar but separate versioning:
https://learn.microsoft.com/en-us/officeupdates/odt-release-history

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie
Copy link
Collaborator

Manifest Error: Package has a single manifest and is a dependency of other manifests. [PackageIdentifier.PackageVersion] Value: Tencent.WeMeetOutlookPlugin.1.2.0.50

I think that this is because it's the highest number version for this PackageIdentifier.

@treysis
Copy link
Contributor Author

treysis commented Apr 23, 2024

I think that this is because it's the highest number version for this PackageIdentifier.

So am I supposed to change the other package?

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Possible-Duplicate New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 23, 2024
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: b03c4cc3c1377ee81b1f94da126e58a30f484d4d935889538fae1c650dd6828b
    • manifests\m\Microsoft\Office\16.0.17531.20046

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit de00b39 into microsoft:master Apr 24, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 24, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Possible-Duplicate Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants