Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Victora.HDD-SSD version 5.37 #151081

Merged
merged 2 commits into from
Apr 26, 2024
Merged

New package: Victora.HDD-SSD version 5.37 #151081

merged 2 commits into from
Apr 26, 2024

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented Apr 25, 2024 •
edited by microsoft-github-policy-service bot

Pull request has been created with komac v2.2.1 馃殌

Resolves: #151058

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge 聽Service Badge 聽

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Apr 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 25, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Domain New-Package labels Apr 25, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Apr 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 25, 2024
@vikingnope vikingnope removed their assignment Apr 26, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Apr 26, 2024
stephengillie
stephengillie previously approved these changes Apr 26, 2024
View reviewed changes
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 26, 2024
@stephengillie stephengillie dismissed their stale review April 26, 2024 15:09

Premature review.

@stephengillie stephengillie removed the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 26, 2024
@stephengillie
Copy link
Collaborator

Verify:
image

@stephengillie stephengillie merged commit a572c7f into microsoft:master Apr 26, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 26, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@github-account1111
Copy link

Thank you. A few issues I found after installing:

  1. You made a typo. It's "Victoria," not "Victora."
  2. "Victoria" is the package name, not "HDD-SSD," so the full identifier should have either been SergeyKazanski.Victoria or Victoria.Victoria like so:
    https://github.com/microsoft/winget-pkgs/tree/master/manifests/c/Celestia/Celestia
  3. The package doesn't appear in the Start menu after installation.

@vikingnope
Copy link
Contributor Author

vikingnope commented May 2, 2024 •
edited

Package Identifier shouldn't affect if it is found or not but I will fix it.

Package will not appear in start menu since it is a portable package

@vikingnope vikingnope deleted the Victora.HDD-SSD-5.37-CAA4DB67C7F146AAB44A6C9F5CC488B7 branch May 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: Victoria HDD/SSD
4 participants
@vikingnope @wingetbot @stephengillie @github-account1111