Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: ReorProject.Reor version 0.2.3 #151258

Merged
merged 3 commits into from
May 20, 2024
Merged

New package: ReorProject.Reor version 0.2.3 #151258

merged 3 commits into from
May 20, 2024

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Apr 27, 2024 •
edited by microsoft-github-policy-service bot

Pull request has been created with komac v2.2.1 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CoolPlayLin CoolPlayLin mentioned this pull request Apr 27, 2024
Merged
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 27, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Apr 29, 2024 •
edited

Automatic Validation ended with:
image

@stephengillie stephengillie removed their assignment Apr 29, 2024
@CoolPlayLin @stephengillie
Apply suggestions from code review
c994944 
Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels May 1, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 1, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented May 1, 2024 •
edited

Manual Validation ended with:
image

This appears to be the dependency. Unfortunately, not seeing it in our package manager yet:

PS C:\ManVal> Find-WinGetPackage vectordb
PS C:\ManVal>

Edit: Verify while here:
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label May 1, 2024
@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented May 1, 2024 •
edited

Hi @samlhuillier
Do you know how to work it out?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 1, 2024
@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 2, 2024
@stephengillie stephengillie removed their assignment May 2, 2024
@CoolPlayLin
Copy link
Contributor Author

It runs normally on my machine

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 4, 2024
@stephengillie
Copy link
Collaborator

It runs normally on my machine

Is it because you already have vectordb installed? This seems to be the issue here - a missing dependency.

@stephengillie stephengillie added Dependencies Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 6, 2024
@CoolPlayLin
Copy link
Contributor Author

CC @reorproject @chuyouchia @samlhuillier @rpdelaney

@samlhuillier
Copy link

Unfortunately this is an issue we've been having with Lancedb and their linking. The solution right now is to install https://aka.ms/vs/17/release/vc_redist.x64.exe on the Windows machine (this installs the c++ runtime which can also be install by downloading and installing Visual Studio).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. New-Package Validation-Completed Validation passed labels May 18, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 18, 2024
@rpdelaney
Copy link

@CoolPlayLin I have never seen this repo before. I assume you accidentally tagged me. Unsubscribing

@stephengillie
Copy link
Collaborator

Verify:
image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 20, 2024
@stephengillie stephengillie merged commit 683875a into microsoft:master May 20, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: Reor
5 participants
@CoolPlayLin @wingetbot @stephengillie @samlhuillier @rpdelaney