Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppsAndFeaturesEntries for Tencent.qq-devtool #152662

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented May 8, 2024

The DisplayVersion is needed for this manifest as at least one previous version of the manifest has a DisplayVersion. Additionally, it is needed as the '_x64' is ommitted from the PackageVersion

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Manifest-Version-Deprecated This manifest schema version is deprecated. The PR should be updated. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 8, 2024
@wingetbot
Copy link
Collaborator

Manifest Schema Version: 1.2.0 less than 1.5.0 for ID: Tencent.qq-devtool and Version: 0.70.2209190

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 8, 2024
@Trenly
Copy link
Contributor Author

Trenly commented May 8, 2024

Intentionally didn't bump version

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Manifest-Version-Deprecated This manifest schema version is deprecated. The PR should be updated. Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 8, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented May 9, 2024

Hi @Trenly,

This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.

(Automated response - build 880.)

Edit: Manual Override

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit fab353a into microsoft:master May 9, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Moderator-Approved One of the Moderators has reviewed and approved this PR labels May 9, 2024
@Trenly Trenly deleted the 3f7c9f71-7cf7-472e-bb82-0b81f13a3504 branch May 9, 2024 02:46
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants