-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RareWares.LAME #155441
Remove RareWares.LAME #155441
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
It doesn't look like https://lame.sourceforge.io/ is hosting any binaries. Isn't a third-party site that provides binaries for open-source codecs fine? Does the manifest really need to be removed? |
URL: https://www.rarewares.org/files/mp3/lame3.100.1-x64.zip (Automated message - build 881) |
I may have overreacted, after finding the FLAC PR. This project only distributes binaries, and links to RareWares on their 3rd party page. I'm not 100% sure which way this one should go, but it kinda feels like this software might not be a good fit for this package manager, because the developer doesn't actually provide an installer for it. |
70f51df
into
microsoft:master
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
I will admit that this is a bit of a shame. RareWares is a very trusted source for builds of various encoders and even Scoop uses this build since there are no others available. But ultimately, I respect your decision if you feel this package doesn't quite fit winget's requirements. I do wish to clarify that RareWares rehosts certain tool (like EAC) but generally encoders and decoders are actually built by the author of the site from original source. Usually downloads will specify if they use the Intel or GCC compiler too. Both FLAC and LAME builds which I submitted are created by the author of the site from the open-source project. |
I would say this one is a bit of an outlier, but since the official site for Lame recognizes RareWares as a location for compiled binaries, I don't have any problems with having the package, but I do want to make sure that the appropriate waivers are maintained, and the manifest has some kind of information regarding the correct license and the actual publisher. |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.RareWares is a 3rd party rehosting site: "Providing hard-to-find pieces of software since 2001-10-21". The actual developer is https://lame.sourceforge.io/
Microsoft Reviewers: Open in CodeFlow