Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RareWares.LAME #155441

Conversation

stephengillie
Copy link
Collaborator

@stephengillie stephengillie commented May 28, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


RareWares is a 3rd party rehosting site: "Providing hard-to-find pieces of software since 2001-10-21". The actual developer is https://lame.sourceforge.io/

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 28, 2024
@stephengillie stephengillie added the Needs-Attention This work item needs to be reviewed by a member of the core team. label May 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 28, 2024
@Blacklands
Copy link

Blacklands commented May 28, 2024

It doesn't look like https://lame.sourceforge.io/ is hosting any binaries. Isn't a third-party site that provides binaries for open-source codecs fine? Does the manifest really need to be removed?

@stephengillie
Copy link
Collaborator Author

URL: https://www.rarewares.org/files/mp3/lame3.100.1-x64.zip
Status Code: 200

(Automated message - build 881)

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels May 28, 2024
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label May 28, 2024
@stephengillie
Copy link
Collaborator Author

I may have overreacted, after finding the FLAC PR. This project only distributes binaries, and links to RareWares on their 3rd party page. I'm not 100% sure which way this one should go, but it kinda feels like this software might not be a good fit for this package manager, because the developer doesn't actually provide an installer for it.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels May 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 70f51df into microsoft:master May 29, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@fgimian
Copy link
Contributor

fgimian commented May 29, 2024

I will admit that this is a bit of a shame. RareWares is a very trusted source for builds of various encoders and even Scoop uses this build since there are no others available. But ultimately, I respect your decision if you feel this package doesn't quite fit winget's requirements.

I do wish to clarify that RareWares rehosts certain tool (like EAC) but generally encoders and decoders are actually built by the author of the site from original source. Usually downloads will specify if they use the Intel or GCC compiler too. Both FLAC and LAME builds which I submitted are created by the author of the site from the open-source project.

@denelon
Copy link
Contributor

denelon commented May 29, 2024

I would say this one is a bit of an outlier, but since the official site for Lame recognizes RareWares as a location for compiled binaries, I don't have any problems with having the package, but I do want to make sure that the appropriate waivers are maintained, and the manifest has some kind of information regarding the correct license and the actual publisher.

@stephengillie stephengillie deleted the Remove-RareWares.LAME branch June 4, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants