Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: DevToys 2.0.1 #156567

Merged

Conversation

veler
Copy link
Contributor

@veler veler commented Jun 5, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Keeping this PR as a draft as the links in the manifest are not available yet (GitHub Release is drafted, not publicly released yet), meaning I can't run the command line to validate the manifest for now.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

1 similar comment
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation label Jun 5, 2024
@wingetbot
Copy link
Collaborator

1 similar comment
@wingetbot
Copy link
Collaborator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 5, 2024
@wingetbot
Copy link
Collaborator

1 similar comment
@wingetbot
Copy link
Collaborator

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation labels Jun 9, 2024
@veler veler marked this pull request as ready for review June 9, 2024 18:33
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 9, 2024
@veler veler changed the title Add DevToys 2.0.1 New package: DevToys 2.0.1 Jun 10, 2024
@stephengillie
Copy link
Collaborator

Verify:
image
image
image

Hi @veler,

The PackageVersion usually should match what's reported by the application, and if this is different from Registry (shown by Apps and features) then the Registry data should be added as a DisplayVersion. Should this be done here, since the application has the .1 before the -preview, but the Registry has it after?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jun 10, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed New-Package labels Jun 11, 2024
@veler
Copy link
Contributor Author

veler commented Jun 11, 2024

Hi @stephengillie, thanks for your feedback and pointing this out.
I updated the installer to reflect the right version number, and therefore updated the PR as the hash changed.
Thank you very much!

image

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 11, 2024
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

2024-06-11 06:57:06.182 [FAIL] Installer failed security check. Url: https://github.com/DevToys-app/DevToys/releases/download/v2.0.1.0/devtoys_win_x64.exe Result: 0x80004005

(Automated response - build 884.)

@veler
Copy link
Contributor Author

veler commented Jun 11, 2024

Manual Validation ended with:

2024-06-11 06:57:06.182 [FAIL] Installer failed security check. Url: https://github.com/DevToys-app/DevToys/releases/download/v2.0.1.0/devtoys_win_x64.exe Result: 0x80004005

(Automated response - build 884.)

That is odd. I just installed the app manually on my machine by downloading the GitHub release and it installed without issue. Can you please elaborate on what happened / what you did?

Thanks

@stephengillie
Copy link
Collaborator

Hi @veler,

That was the scripted response when one of my VMs gets a Defender error. In this case, it was signature/definition version 1.411.160.0.

DevToys-app.DevToys.2.0.1.log

It's probably a false positive, and we can rescan tomorrow.

@veler
Copy link
Contributor Author

veler commented Jun 11, 2024

Hi @veler,

That was the scripted response when one of my VMs gets a Defender error. In this case, it was signature/definition version 1.411.160.0.

DevToys-app.DevToys.2.0.1.log

It's probably a false positive, and we can rescan tomorrow.

Thank you! Yes, can we please run the validation again (whenever possible, tomorrow is fine) ?
There literally nothing that changed compared to before except the string of the version number.

@stephengillie
Copy link
Collaborator

@wingetbot run

@stephengillie
Copy link
Collaborator

stephengillie commented Jun 12, 2024

Verify:
image
image
image

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 0ffa588 into microsoft:master Jun 12, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 12, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@masterflitzer
Copy link

something with the version doesn't seem to be right, it says 2.0-preview.1 is installed, but keeps offering me 2.0.1, so i'm basically in an infinite update loop

it seems to ignore the -preview part of the version (the winget-pkgs path also doesn't have it: https://github.com/microsoft/winget-pkgs/tree/master/manifests/d/DevToys-app/DevToys/2.0.1)

the command i'm using is winget source update && winget upgrade -r
console output:

❯ winget source update && winget upgrade -r
Updating all sources...
Updating source: winget...
Done
Name                                  Id                  Version       Available
---------------------------------------------------------------------------------
DevToys Preview version 2.0-preview.1 DevToys-app.DevToys 2.0-preview.1 2.0.1
1 upgrades available.
6 package(s) have pins that prevent upgrade. Use the 'winget pin' command to view and edit pins. Using the --include-pinned argument may show more results.

(1/1) Found DevToys [DevToys-app.DevToys] Version 2.0.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/DevToys-app/DevToys/releases/download/v2.0.1.0/devtoys_win_x64.exe
  ██████████████████████████████  55.5 MB / 55.5 MB
Successfully verified installer hash
Starting package install...
Successfully installed

29 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.

~ took 42s
❯ winget source update && winget upgrade
Updating all sources...
Updating source: winget...
Done
Name                                  Id                  Version       Available
---------------------------------------------------------------------------------
DevToys Preview version 2.0-preview.1 DevToys-app.DevToys 2.0-preview.1 2.0.1
1 upgrades available.
6 package(s) have pins that prevent upgrade. Use the 'winget pin' command to view and edit pins. Using the --include-pinned argument may show more results.

~ took 2s
❯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed Validation-Defender-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants