Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foobar2000 #1770

Closed
wants to merge 8 commits into from
Closed

Add foobar2000 #1770

wants to merge 8 commits into from

Conversation

Witchilich
Copy link
Contributor

@Witchilich Witchilich commented Jun 10, 2020 •
edited by ghost

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error Indicates and error was encountered during InstallerScan test. label Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

Restia666Ashdoll The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot removed Binary-Validation-Error Indicates and error was encountered during InstallerScan test. Needs: author feedback labels Jun 10, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 10, 2020
@ghost ghost assigned denelon Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

This submission has moved to manual review.

@Witchilich Witchilich mentioned this pull request Jun 10, 2020
Closed
@Witchilich
Copy link
Contributor Author

Witchilich commented Jun 10, 2020 •
edited

Had to change the URL to Videohelp, because winget cant pick the official link
#259

@KevinLaMS KevinLaMS added the Validation-Hash-Verification-Failed During manual testing, the Sha256 value no longer matches the installer. label Jun 14, 2020
@ghost
Copy link

ghost commented Jun 14, 2020

Restia666Ashdoll I am sorry to report that the Sha256 Hash does not match the installer. This maybe caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 14, 2020
@KevinLaMS
Copy link
Contributor

Change of redirect must have changed the hash.

@wingetbot wingetbot removed Needs: author feedback Validation-Hash-Verification-Failed During manual testing, the Sha256 value no longer matches the installer. labels Jun 14, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error Indicates and error was encountered during InstallerScan test. label Jun 14, 2020
@ghost
Copy link

ghost commented Jun 14, 2020

Restia666Ashdoll The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@Witchilich Witchilich mentioned this pull request Jun 14, 2020
Closed
@Witchilich
Copy link
Contributor Author

@KevinLaMS winget should just be able to pick Videohelp links like Scoop
https://github.com/lukesampson/scoop-extras/blob/master/bucket/foobar2000.json

@ghost ghost removed the Needs: author feedback label Jun 14, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot removed the Binary-Validation-Error Indicates and error was encountered during InstallerScan test. label Jul 1, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error Indicates and error was encountered during InstallerScan test. label Jul 1, 2020
@ghost
Copy link

ghost commented Jul 1, 2020

Restia666Ashdoll The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jul 8, 2020
@ghost
Copy link

ghost commented Jul 8, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ashpatil-msft
Copy link
Contributor

/AzurePipelines run

@ghost ghost removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Jul 8, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Error-Installer-Availability The installer was not available to validate (HTTP Issue) and removed Binary-Validation-Error Indicates and error was encountered during InstallerScan test. Needs: author feedback labels Jul 8, 2020
@ashpatil-msft
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Jul 17, 2020
@denelon
Copy link
Contributor

denelon commented Jul 17, 2020

@EndlessBernkastel it seems they would prefer not to be included in the Windows Package Manager.

https://hydrogenaud.io/index.php?topic=119506.0

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Witchilich
Copy link
Contributor Author

@denelon I guess we should stick to trying to make Videohelp links work like Scoop. There does not seem to any comment from the dev, just an opinion from another dev.

@denelon denelon closed this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@denelon denelon

Labels
Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Error-Installer-Availability The installer was not available to validate (HTTP Issue)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Witchilich @wingetbot @KevinLaMS @ashpatil-msft @denelon