Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Google.Chrome to version 92.0.4515.107 #21946

Merged
1 commit merged into from Jul 22, 2021
Merged

Updated Google.Chrome to version 92.0.4515.107 #21946

1 commit merged into from Jul 22, 2021

Conversation

ImJoakim
Copy link
Contributor

@ImJoakim ImJoakim commented Jul 21, 2021 •
edited by ghost

image

PS C:\Users\WDAGUtilityAccount\Desktop\manifests> winget install -m "C:\Users\WDAGUtilityAccount\Desktop\manifests\g\Google\Chrome\92.0.4515.107"
Found Google Chrome [Google.Chrome]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://dl.google.com/edgedl/chrome/install/GoogleChromeStandaloneEnterprise64.msi
  ██████████████████████████████  76.2 MB / 76.2 MB
Successfully verified installer hash
Starting package install...
Successfully installed

image

PS C:\Users\WDAGUtilityAccount\Desktop\manifests> winget install -m "C:\Users\WDAGUtilityAccount\Desktop\manifests\g\Google\Chrome\92.0.4515.107"
Found Google Chrome [Google.Chrome]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://dl.google.com/edgedl/chrome/install/GoogleChromeStandaloneEnterprise.msi
  ██████████████████████████████  73.5 MB / 73.5 MB
Successfully verified installer hash
Starting package install...
Successfully installed
  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Jul 21, 2021
@ghost
Copy link

ghost commented Jul 21, 2021

Hello @ImJoakim,
I am sorry to report that the Sha256 Hash does not match the installer. This maybe caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 21, 2021
ImJoakim
ImJoakim commented Jul 21, 2021
View reviewed changes
Copy link
Contributor Author

@ImJoakim ImJoakim left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the suggestion was deleted so I was forced to "review" because I tried to comment while it was deleted.

@ghost ghost added Needs: Attention and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 21, 2021
@ImJoakim
Copy link
Contributor Author

Need to wait a little and re-run it.

@ImJoakim ImJoakim closed this Jul 21, 2021
@ImJoakim ImJoakim reopened this Jul 21, 2021
@ImJoakim
Copy link
Contributor Author

Heya @OfficialEsco, do you know anything about a change made to when the bot is running /AzurePipelines run? It doesn't seem to run that command/comment after close -> open anymore.

@OfficialEsco
Copy link
Contributor

OfficialEsco commented Jul 21, 2021 •
edited

No idea, seems to act very weird since they got back to work this week, hopefully its a side effect of them being in the middle of something, and didn't fix it before leaving yesterday..

It also seems like its just the msges that are delayed cuz i get a buuuunch of messages at the same time, like i got 30+ mails right now in a 1min timespan lmao

It also seems like its forgetting to merge at times, then remembering it when Levvie reapproves #21932

AND it keeps trying to cheat the system >:C #21903 (review)

@ImJoakim
Copy link
Contributor Author

No idea, seems to act very weird since they got back to work this week, hopefully its a side effect of them being in the middle of something, and didn't fix it before leaving yesterday..

It also seems like its just the msges that are delayed cuz i get a buuuunch of messages at the same time, like i got 30+ mails right now in a 1min timespan lmao

Yeah, it's acting really unusual.

@OfficialEsco
Copy link
Contributor

Ahh nvm, there is no schedule, the bot just pick random PR's, #21949 (comment) have been idle for 2 hours while a bunch of my PR's have gone trough

@ImJoakim
Copy link
Contributor Author

Oof

@ImJoakim ImJoakim closed this Jul 21, 2021
@ImJoakim ImJoakim reopened this Jul 21, 2021
@ImJoakim
Copy link
Contributor Author

ImJoakim commented Jul 21, 2021 •
edited

Whoops, that was not the Comment button haha

Edit: Well, technically the word Comment is included in that button :p

@vedantmgoyal9
Copy link
Contributor

There are doing changes to validation merge.
Issue: #21008
Milestone: https://github.com/microsoft/winget-pkgs/milestone/11?closed=1

@OfficialEsco
Copy link
Contributor

That is just so us Moderators can Approve before its Validated, has nothing to do with this

@vedantmgoyal9
Copy link
Contributor

vedantmgoyal9 commented Jul 21, 2021 •
edited

I don't know correctly, but I think they have made changes in msftbot and wingetbot due to which wingetbot forgets to comment and msftbot does not merge it instantly once the PR is approved like it had done before.

@denelon
Copy link
Contributor

denelon commented Jul 22, 2021

We're trying to make the bot a bit smarter, and it seems to be responding by becoming either slower or nondeterministic with it's responses.

@ImJoakim ImJoakim closed this Jul 22, 2021
@ImJoakim ImJoakim reopened this Jul 22, 2021
@ImJoakim
Copy link
Contributor Author

ImJoakim commented Jul 22, 2021 •
edited

Worth a shot hehe. @denelon can you re-run it.

Edit: nevermind :o

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs: Attention labels Jul 22, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

Hello @ImJoakim,
Validation has completed.

@ghost ghost merged commit acf57f2 into microsoft:master Jul 22, 2021
@ImJoakim ImJoakim deleted the Updated-Google.Chrome branch July 22, 2021 11:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ImJoakim @wingetbot @OfficialEsco @vedantmgoyal9 @denelon @ItzLevvie