Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WildfireGames.0AD version 0.0.25b #28868

Merged
8 commits merged into from Oct 1, 2021
Merged

WildfireGames.0AD version 0.0.25b #28868

8 commits merged into from Oct 1, 2021

Conversation

DanielAtKrypton
Copy link
Contributor

@DanielAtKrypton DanielAtKrypton commented Sep 28, 2021 •
edited by ghost

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost
Copy link

ghost commented Sep 28, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 28, 2021
@ghost
Copy link

ghost commented Sep 28, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Sep 29, 2021
@DanielAtKrypton @ItzLevvie
Update manifests/w/WildfireGames/0AD/0.0.25b/WildfireGames.0AD.locale…
37ba4db 
….en-US.yaml


Commit suggestion 1

Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Sep 29, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@DanielAtKrypton @ItzLevvie
Update manifests/w/WildfireGames/0AD/0.0.25b/WildfireGames.0AD.instal…
398fb5f 
…ler.yaml


Commit suggestion

Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 28868 in repo microsoft/winget-pkgs

@DanielAtKrypton @ItzLevvie
Update manifests/w/WildfireGames/0AD/0.0.25b/WildfireGames.0AD.yaml
eb07d1c 
Commit suggestion

Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 28868 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@DanielAtKrypton @ItzLevvie
Update manifests/w/WildfireGames/0AD/0.0.25b/WildfireGames.0AD.locale…
21dad65 
….en-US.yaml


Commit suggestion

Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 28868 in repo microsoft/winget-pkgs

@DanielAtKrypton @ItzLevvie
Update manifests/w/WildfireGames/0AD/0.0.25b/WildfireGames.0AD.locale…
ad439f7 
….en-US.yaml


Commit suggestion

Co-authored-by: Levvie - she/her <11600822+ItzLevvie@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Sep 29, 2021
@ghost
Copy link

ghost commented Sep 29, 2021

Hello @DanielAtKrypton,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Sep 29, 2021
@ItzLevvie
Copy link
Contributor

You will need to update the version folder as well: from 0.0.25b to r25860-alpha

@ghost ghost removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Sep 30, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DanielAtKrypton
Merge branch 'master' of github.com:microsoft/winget-pkgs into autoge…
e8c2c55 
…nerated/WildfireGames.0AD/c9242241-de6a-4a06-93e9-ba25b95fbc54

Rebase master into 0 A.D. 25b PR branch.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 30, 2021
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 30, 2021
@ghost
Copy link

ghost commented Sep 30, 2021

Hello @DanielAtKrypton,
Validation has completed.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Oct 1, 2021
@ghost
Copy link

ghost commented Oct 1, 2021

Hello @DanielAtKrypton,
Validation has completed.

@ghost ghost merged commit 3d00f9d into microsoft:master Oct 1, 2021
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@KaranKad KaranKad mentioned this pull request Nov 20, 2021
Closed
5 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielAtKrypton @wingetbot @ItzLevvie