Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add xmake v2.3.6 #2941

Merged
5 commits merged into from
Aug 19, 2020
Merged

add xmake v2.3.6 #2941

5 commits merged into from
Aug 19, 2020

Conversation

waruqi
Copy link
Contributor

@waruqi waruqi commented Aug 7, 2020 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@waruqi waruqi mentioned this pull request Aug 7, 2020
Closed
4 tasks
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 7, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

waruqi The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added Needs: Attention and removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels Aug 7, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 7, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This submission has moved to manual review.

@ghost ghost assigned KevinLaMS Aug 7, 2020
@ghost ghost removed the Needs: Attention label Aug 7, 2020
@KevinLaMS KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Aug 7, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying WDNotify@microsoft.com for investigation.

@ghost ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Aug 7, 2020
@perplexityjeff
Copy link
Contributor

I'd suggest to add the switches to the end of the file as well?

Switches:
Silent: /S
SilentWithProgress: /S

@ghost ghost removed Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation Needs SmartScreen Investigation labels Aug 7, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 7, 2020
@ghost ghost assigned denelon Aug 7, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This submission has moved to manual review.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application Needs: Attention labels Aug 14, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Error-Installer-Availability The installer was not available to validate (HTTP Issue) label Aug 14, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

waruqi:
When processing this package, the URL to the installer returned a 404 error or was determined to be invalid.

Please update the URL and hash at your convenience and resubmit your PR.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added Needs: Attention and removed Needs: author feedback Error-Installer-Availability The installer was not available to validate (HTTP Issue) labels Aug 14, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 14, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

This submission has moved to manual review.

@ghost ghost removed the Needs: Attention label Aug 14, 2020
@waruqi
Copy link
Contributor Author

waruqi commented Aug 14, 2020

@waruqi I am not an expert on NSIS by far but maybe this change that was made in FileZilla can help you as well. or wait until winget supports using custom exit codes for success.

https://forum.filezilla-project.org/viewtopic.php?t=36679
https://svn.filezilla-project.org/filezilla/FileZilla3/trunk/data/install.nsi.in?r1=6557&r2=6628&pathrev=6628

@perplexityjeff I have fixed it, thanks!

@perplexityjeff
Copy link
Contributor

@waruqi I can confirm as well when testing your file that it all works fine, nice!

@denelon, @KevinLaMS I think we are all set to merge?

@KevinLaMS KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Aug 14, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying WDNotify@microsoft.com for investigation.

@ghost ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Aug 14, 2020
@waruqi
Copy link
Contributor Author

waruqi commented Aug 17, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying WDNotify@microsoft.com for investigation.

? What is this problem?

@perplexityjeff
Copy link
Contributor

@waruqi, SmartScreen got triggered during installation. I hope that the team can fix this for you and get it merged, I can't help you with this one :(. I see no reason why it would not get fixed tho.

Maybe we can get @KevinLaMS to get a status?

@waruqi
Copy link
Contributor Author

waruqi commented Aug 17, 2020

@waruqi, SmartScreen got triggered during installation. I hope that the team can fix this for you and get it merged, I can't help you with this one :(. I see no reason why it would not get fixed tho.

Maybe we can get @KevinLaMS to get a status?

@perplexityjeff Ok, Thanks!

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Aug 19, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 137f366 into microsoft:master Aug 19, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@KevinLaMS KevinLaMS

@denelon denelon

Labels
Validation-Completed Validation passed Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@waruqi @wingetbot @perplexityjeff @KevinLaMS @denelon