Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E-Viewer 2011.11.1 #4996

Closed
wants to merge 4 commits into from
Closed

Add E-Viewer 2011.11.1 #4996

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

To install this application, you need to manually trust the personal signature of this developer. Please install the .cer file here.
https://github.com/OpportunityLiu/E-Viewer/releases/tag/v2020.11.1

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

g-aghayev The package manager bot determined that the metadata was not compliant. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@ghost ghost added Needs: Attention and removed Needs: author feedback Manifest-Validation-Error Manifest validation failed labels Nov 24, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link
Author

ghost commented Nov 24, 2020

You need to indicate in the document a warning that multiple architectures are not supported.
microsoft/winget-cli#132

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

This submission has moved to manual review.

@ghost ghost assigned denelon Nov 24, 2020
@ghost ghost removed the Needs: Attention label Nov 24, 2020
@ghost ghost changed the title add E-Viewer 2011.11.1 Add E-Viewer 2011.11.1 Nov 24, 2020
@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

g-aghayev The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@KevinLaMS
Copy link
Contributor

KevinLaMS commented Nov 24, 2020

image
tweak image

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Nov 24, 2020
@ghost
Copy link
Author

ghost commented Nov 25, 2020

Please see my reminder in #4996 (comment)

To install this application, you need to manually trust the personal signature of this developer. Please install the .cer file here.
https://github.com/OpportunityLiu/E-Viewer/releases/tag/v2020.11.1

The .cer file direct link -> https://github.com/OpportunityLiu/E-Viewer/releases/download/v2020.11.1/ExViewer_2020.11.1.0_x64.cer
Install as Trusted People
If there is a simpler method that does not require the user to manually operate to trust a certain certificate, please let me know.

@denelon
Copy link
Contributor

denelon commented Apr 30, 2021

/azp run

@ghost ghost removed Validation-Installation-Error Error installing application Needs: Attention labels Apr 30, 2021
@azure-pipelines
Copy link

No commit pushedDate could be found for PR 4996 in repo microsoft/winget-pkgs

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

@ghost The package manager bot determined that the metadata was not compliant.

As mentioned in this tweet, in winget-cli and winget-pkgs we have moved to the 1.0 format. Please update your manifest to the new format and submit again.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://github.com/microsoft/winget-cli/blob/master/doc/ManifestSpecv1.0.md)
For details on the error, see the details link below in the build pipeline.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 7, 2021
@ghost
Copy link

ghost commented May 7, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this May 14, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manifest-Validation-Error Manifest validation failed No-Recent-Activity No activity has occurred on this work item for seven days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants